[ovs-dev] [PATCH] netdev-afxdp: updated documentation

Ilya Maximets i.maximets at ovn.org
Fri Dec 4 19:15:56 UTC 2020


On 12/2/20 7:21 PM, Toms Atteka wrote:
> If system is missing ethtool, test fails silently.
> 
> Signed-off-by: Toms Atteka <cpp.code.lv at gmail.com>
> ---
>  Documentation/intro/install/afxdp.rst | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/Documentation/intro/install/afxdp.rst b/Documentation/intro/install/afxdp.rst
> index 3c8f78825..a597658e2 100644
> --- a/Documentation/intro/install/afxdp.rst
> +++ b/Documentation/intro/install/afxdp.rst
> @@ -166,7 +166,7 @@ Finally, build and install OVS::
>  
>  To kick start end-to-end autotesting::
>  
> -  uname -a # make sure having 5.0+ kernel
> +  uname -a # make sure having 5.0+ kernel and ethtool installed

This comment is for 'uname -a', so ethtool related information
doesn't belong there.  It's better to write an extra sentence
before actual commands to describe requirements.

Something like this:
---
To kick start end-to-end autotesting (make sure having 5.0+ kernel and ethtool
installed)::

  make check-afxdp TESTSUITEFLAGS='1'
---

What do you think?

Best regards, Ilya Maximets.


More information about the dev mailing list