[ovs-dev] [PATCH ovn v9 4/7] tests: Eliminate most "sleep" calls.

Dumitru Ceara dceara at redhat.com
Fri Dec 11 12:36:25 UTC 2020


On 12/2/20 7:50 AM, Ben Pfaff wrote:
> Many of these could be replaced by "ovn-nbctl sync".  Some weren't
> really needed at all because they were adjacent to something that itself
> called sync or otherwise used --wait.  Some were more appropriately
> done with explicit waits for what was really needed.
> 
> I left some "sleep"s.  Some were because they were "negative" sleeps:
> they were giving time for something to happen that should *not* happen
> (in other words, if you wait for it to happen, you'll wait forever,
> unless there's a bug).  Some were because I didn't know how to properly
> wait for what they were waiting for, or because I didn't understand
> the circumstances deeply enough.
> 
> Signed-off-by: Ben Pfaff <blp at ovn.org>
> ---

Hi Ben,

I have a tiny nit below, with that addressed:

Acked-by: Dumitru Ceara <dceara at redhat.com>

[...]

>  
> diff --git a/tests/ovn.at b/tests/ovn.at
> index 63629af7e9a8..053889f87ba0 100644
> --- a/tests/ovn.at
> +++ b/tests/ovn.at

[...]

>  
>  # Pre-populate the hypervisors' ARP tables so that we don't lose any
> @@ -3760,8 +3760,7 @@ check ovn-nbctl --wait=hv sync
>  # for ARP resolution).
>  OVN_POPULATE_ARP
>  
> -# Allow some time for ovn-northd and ovn-controller to catch up.
> -# XXX This should be more systematic.
> +check ovn-nbctl --wait=hv sync

Nit: I think this can be remove completely.  We do a --wait=hv sync just
above.

Thanks,
Dumitru



More information about the dev mailing list