[ovs-dev] [PATCH ovn v4 0/3] IPAM refactor and unit tests

Mark Michelson mmichels at redhat.com
Wed Dec 16 17:48:44 UTC 2020


This is version 4 of a patch series that formerly introduced a new unit test
framework into OVN.

In this version, the new unit test framework has been removed. It
instrucmented existing code rather than living separately, and that was
not appreciated by those who were reviewing the changes. In this new
version, I am taking the IPAM refactoring and the tests I added for
IPAM, and I am reworking them to just use ovstest instead.

Some additional unit test scaffolding may at some point be required if,
for instance, we wish to mock interaction with a database or with OVS.
That, however, is not necessary for the tests being added here.

Mark Michelson (3):
  northd: refactor and split some IPAM functions
  Add ipam unit tests
  Disable logging to the console from ovstest.

 northd/automake.mk      |   5 +-
 northd/ipam.c           | 327 ++++++++++++++++++++++++++++++++++++++++
 northd/ipam.h           |  42 ++++++
 northd/ovn-northd.c     | 285 +++-------------------------------
 northd/test-ipam.c      | 138 +++++++++++++++++
 tests/automake.mk       |   8 +-
 tests/ovn-unit-tests.at | 237 +++++++++++++++++++++++++++++
 tests/ovstest.c         |  17 +++
 tests/testsuite.at      |   1 +
 9 files changed, 792 insertions(+), 268 deletions(-)
 create mode 100644 northd/ipam.c
 create mode 100644 northd/ipam.h
 create mode 100644 northd/test-ipam.c
 create mode 100644 tests/ovn-unit-tests.at

-- 
2.25.4



More information about the dev mailing list