[ovs-dev] [PATCH ovn] Set release date for 20.12.0

Numan Siddique numans at ovn.org
Fri Dec 18 15:14:42 UTC 2020


On Fri, Dec 18, 2020 at 8:18 PM Ilya Maximets <i.maximets at ovn.org> wrote:
>
> On 12/18/20 2:39 PM, Mark Michelson wrote:
> > On 12/17/20 2:31 PM, Numan Siddique wrote:
> >> On Thu, Dec 17, 2020 at 11:39 PM Mark Michelson <mmichels at redhat.com> wrote:
> >>>
> >>> Signed-off-by: Mark Michelson <mmichels at redhat.com>
> >>
> >>  From the previous release patches, I have not seen a patch to master
> >> branch to set the date.
> >>
> >> But I have nothing against it.
> >>
> >> Acked-by: Numan Siddique <numans at ovn.org> for the entire 3-patch series.
> >>
> >> Thanks
> >> Numan
> >>
> >
> > OK, no need to rock the boat at this point, I suppose. I've left the master commit out.
>
> That is strange.  There should be commit on master branch
> that updates an actual date, otherwise we will have 'xx xxx xxxx'
> instead of a release date and this will be forked to all future
> branches on next releases too.
>
> OVS always had this kind of a patch.  See:
>   git log --grep 'Set release date'
>
> OVN releases are a bit sketchy, but you can still find this
> commit for 20.09.
>
> Documentation in OVN repo doesn't talk about this particular type
> of a patch, but Ben clarified the process in February for OVS.
> You can find it here:
>   https://docs.openvswitch.org/en/latest/internals/release-process/#how-to-release
>
> Maybe, we need to cherry-pick this change to OVN repo to avoid
> misinterpretations.

Thanks for sharing this. When I reviewed these patches, I referred to
your patches
which you submitted for 2.14 release [1] and noticed that you didn't
submit the patch to the master branch, but only 2 patches to branch-2.14.

So what we have essentially missed is the step 5 mentioned in the link
you shared.
So I suppose Mark should also apply patch 2 of this series to the
master branch since
z = 0. (Mark dropped patch 1 of this series when he applied).

I agree, it's better to cherry-pick the #how-to-release step to OVN repo too.

Thanks
Numan

[1] - https://patchwork.ozlabs.org/project/openvswitch/list/?series=195999&state=*


>
> Thoughts?
>
> Best regards, Ilya Maximets.
>
> >
> > I pushed the branch-20.12 commits and tagged version 20.12.0. I've also put up a PR for the ovn-website: https://github.com/ovn-org/ovn-website/pull/18
> >
> >>
> >>> ---
> >>>   NEWS             | 2 +-
> >>>   debian/changelog | 4 ++--
> >>>   2 files changed, 3 insertions(+), 3 deletions(-)
> >>>
> >>> diff --git a/NEWS b/NEWS
> >>> index f0ac94b8e..ce0781cbc 100644
> >>> --- a/NEWS
> >>> +++ b/NEWS
> >>> @@ -2,7 +2,7 @@ Post-v20.12.0
> >>>   -------------------------
> >>>     - Support ECMP multiple nexthops for reroute router policies.
> >>>
> >>> -OVN v20.12.0 - xx xxx xxxx
> >>> +OVN v20.12.0 - 18 Dec 2020
> >>>   --------------------------
> >>>      - The "datapath" argument to ovn-trace is now optional, since the
> >>>        datapath can be inferred from the inport (which is required).
> >>> diff --git a/debian/changelog b/debian/changelog
> >>> index e35f114a9..cac9a2ab9 100644
> >>> --- a/debian/changelog
> >>> +++ b/debian/changelog
> >>> @@ -2,13 +2,13 @@ ovn (20.12.90-1) unstable; urgency=low
> >>>
> >>>      * New upstream version
> >>>
> >>> - -- OVN team <dev at openvswitch.org>  Mon, 07 Dec 2020 19:58:40 +0530
> >>> + -- OVN team <dev at openvswitch.org>  Fri, 18 Dec 2020 11:33:47 -0500
> >>>
> >>>   ovn (20.12.0-1) unstable; urgency=low
> >>>
> >>>      * New upstream version
> >>>
> >>> - -- OVN team <dev at openvswitch.org>  Mon, 07 Dec 2020 19:22:36 +0530
> >>> + -- OVN team <dev at openvswitch.org>  Fri, 18 Dec 2020 11:33:47 -0500
> >>>
> >>>   ovn (20.09.0-1) unstable; urgency=low
> >>>
> >>> --
> >>> 2.25.4
> >>>
> >>> _______________________________________________
> >>> dev mailing list
> >>> dev at openvswitch.org
> >>> https://mail.openvswitch.org/mailman/listinfo/ovs-dev
> >>>
> >>
> >
> > _______________________________________________
> > dev mailing list
> > dev at openvswitch.org
> > https://mail.openvswitch.org/mailman/listinfo/ovs-dev
> >
>
> _______________________________________________
> dev mailing list
> dev at openvswitch.org
> https://mail.openvswitch.org/mailman/listinfo/ovs-dev


More information about the dev mailing list