[ovs-dev] [PATCH v4 1/3] dpif-netdev: Add parameters to configure auto load balance.

[Kevin Traynor]

On 18/12/2020 15:55, David Marchand wrote:
> On Thu, Dec 17, 2020 at 8:23 PM Kevin Traynor <ktraynor at redhat.com> wrote:
>>
>> From: Christophe Fontaine <cfontain at redhat.com>
>>
>> Two important parts of how auto load balance operates is how
>> loaded a core needs to be and how much improvement is estimated
>> before an auto load balance can trigger.
>>
>> Previously they were hardcoded to 95% loaded and 25% variance
>> improvement.
>>
>> These default values may not be suitable for all use cases and
>> we may want to use a more (or less) aggressive rebalance, either
>> on the pmd load threshold or on the minimum variance improvement
>> threshold.
>>
>> The defaults are not changed, but "pmd-auto-lb-pmd-load" and
>> "pmd-auto-lb-improvement" parameters are added to override the defaults.
>>
>> $ ovs-vsctl set open_vswitch . other_config:pmd-auto-lb-pmd-load="70"
>> $ ovs-vsctl set open_vswitch . other_config:pmd-auto-lb-improvement="20"
>>
>> Signed-off-by: Christophe Fontaine <cfontain at redhat.com>
>> Signed-off-by: Kevin Traynor <ktraynor at redhat.com>
> 
> Acked-by: David Marchand <david.marchand at redhat.com>
> 
> Just a nit: we could use a single denomination like *PMD* auto load
> balancing/balance in both NEWS and the database fields description for
> consistency and avoid confusion with other OVS features.
> 

Thanks David. I was also missing a Co-Authored-by, so I made this more
consistent and sent a v5.

> 
> --
> David Marchand
>