[ovs-dev] [PATCH v6 1/4] dpif-netdev: Add log for PMD auto load balance interval parameter.

Kevin Traynor ktraynor at redhat.com
Mon Dec 21 13:10:30 UTC 2020


Previously if the parameter for the PMD auto load balance minimum
interval was changed at runtime, it was not logged unless the
PMD auto load balance feature was also changed to enabled.

Log the parameter anytime it changes, and use minutes when it is
logged as that is the user input format.

Fixes: 5bf84282482a ("Adding support for PMD auto load balancing")
Cc: nitin.katiyar at ericsson.com
Signed-off-by: Kevin Traynor <ktraynor at redhat.com>
Acked-by: David Marchand <david.marchand at redhat.com>
---
 lib/dpif-netdev.c | 6 ++++--
 1 file changed, 4 insertions(+), 2 deletions(-)

diff --git a/lib/dpif-netdev.c b/lib/dpif-netdev.c
index 300861ca5..d19d5bbff 100644
--- a/lib/dpif-netdev.c
+++ b/lib/dpif-netdev.c
@@ -4235,6 +4235,6 @@ set_pmd_auto_lb(struct dp_netdev *dp)
         if (pmd_alb->is_enabled) {
             VLOG_INFO("PMD auto load balance is enabled "
-                      "(with rebalance interval:%"PRIu64" msec)",
-                       pmd_alb->rebalance_intvl);
+                      "interval %"PRIu64" mins",
+                       pmd_alb->rebalance_intvl / MIN_TO_MSEC);
         } else {
             pmd_alb->rebalance_poll_timer = 0;
@@ -4345,4 +4345,6 @@ dpif_netdev_set_config(struct dpif *dpif, const struct smap *other_config)
     if (pmd_alb->rebalance_intvl != rebalance_intvl) {
         pmd_alb->rebalance_intvl = rebalance_intvl;
+        VLOG_INFO("PMD auto load balance interval set to "
+                  "%"PRIu64" mins\n", rebalance_intvl / MIN_TO_MSEC);
     }
 
-- 
2.26.2



More information about the dev mailing list