[ovs-dev] [PATCH] ovs-monitor-ipsec: Suppress "unknown %d argument" warning

Mark Gray mark.d.gray at redhat.com
Mon Dec 21 13:12:33 UTC 2020


As 'ovs-vswitchd' does not understand IPsec tunnel options, it
gives a warning message. This can be safely suppressed.

Signed-off-by: Mark Gray <mark.d.gray at redhat.com>
---
 lib/netdev-vport.c | 8 ++++++++
 1 file changed, 8 insertions(+)

diff --git a/lib/netdev-vport.c b/lib/netdev-vport.c
index 0252b61dea2b..7c99f790dfc2 100644
--- a/lib/netdev-vport.c
+++ b/lib/netdev-vport.c
@@ -745,6 +745,14 @@ set_tunnel_config(struct netdev *dev_, const struct smap *args, char **errp)
                     goto out;
                 }
             }
+        } else if (!strcmp(node->key, "remote_cert") ||
+                   !strcmp(node->key, "remote_name") ||
+                   !strcmp(node->key, "psk")) {
+            /* When configuring OVS for IPsec, these keys may be set in the
+               tunnel port's 'options' column. 'ovs-vswitchd' does not directly
+               use them, but they are read by 'ovs-monitor-ipsec'. In order to
+               suppress the "unknown %s argument" warning message below, we
+               handle them here by ignoring them. */
         } else {
             ds_put_format(&errors, "%s: unknown %s argument '%s'\n", name,
                           type, node->key);
-- 
2.26.2



More information about the dev mailing list