[ovs-dev] [PATCH 60/62] dpif-netdev: modify max supported number of meter

[taoyunxiang at cmss.chinamobile.com]

>On Tue, Dec 29, 2020 at 10:28 AM Tonghao Zhang <xiangxia.m.yue at gmail.com> wrote:
>>
>> On Tue, Dec 29, 2020 at 2:13 AM Tao YunXiang
>> <taoyunxiang at cmss.chinamobile.com> wrote:
>> >
>> > From: Taoyunxiang <taoyunxiang at cmss.chinamobile.com>
>> >
>> > Code Source From: Self Code
>> >
>> > Description:
>> > The max number is assigned by dpif_netdev_meter_get_features.
>> > The max supported number in BSC card is 256.
>> > So we need to modify the default max number
>> > from 65536 to 256.
>> > In ofproto-dpif.c, meter_set will verify max number by
>> > id_pool_alloc_id.
>> >
>> > Jira:  #[Optional]
>> > 市场项目编号（名称）：[Optional]
>> > ---
>> >  lib/dpif-netdev.c | 3 ++-
>> >  1 file changed, 2 insertions(+), 1 deletion(-)
>> >
>> > diff --git a/lib/dpif-netdev.c b/lib/dpif-netdev.c
>> > index cf89d6c..1f5fce5 100644
>> > --- a/lib/dpif-netdev.c
>> > +++ b/lib/dpif-netdev.c
>> > @@ -98,7 +98,8 @@ DEFINE_STATIC_PER_THREAD_DATA(uint32_t, recirc_depth, 0)
>> >
>> >  /* Configuration parameters. */
>> >  enum { MAX_FLOWS = 65536 };     /* Maximum number of flows in flow table. */
>> > -enum { MAX_METERS = 65536 };    /* Maximum number of meters. */
>> > +enum { MAX_METERS = 256 };    /* Maximum number of meters.
>> > +                                 256 is the max supported number in Intel BSC card*/
>> No ack
>> why change 65536 --> 256. I guess 256 is too small
>And some case, we should expand the meters
>http://patchwork.ozlabs.org/project/openvswitch/list/?series=178840
 
I see this summit ,it is nice.

We want to share meter config for different flows in HW.  So many flows coud use a specified meter config.
We designed the limit in HW. 

>
>> >  enum { MAX_BANDS = 8 };         /* Maximum number of bands / meter. */
>> >  enum { N_METER_LOCKS = 64 };    /* Maximum number of meters. */
>> >
>> > --
>> > 1.8.3.1
>> >
>> >
>> >
>> > _______________________________________________
>> > dev mailing list
>> > dev at openvswitch.org
>> > https://mail.openvswitch.org/mailman/listinfo/ovs-dev
>>
>>
>>
>> --
>> Best regards, Tonghao
>
>
>
>--
>Best regards, Tonghao