[ovs-dev] [PATCH v1 1/2] ovs-numa: Non-consecutively numa nodes and cores

0-day Robot robot at bytheb.org
Wed Feb 5 21:58:56 UTC 2020


Bleep bloop.  Greetings David Wilder, I am a robot and I have tried out your patch.
Thanks for your contribution.

I encountered some error that I wasn't expecting.  See the details below.


checkpatch:
WARNING: Line is 80 characters long (recommended limit is 79)
WARNING: Line lacks whitespace around operator
#74 FILE: lib/ovs-numa.c:183:
    path = xasprintf("/sys/devices/system/cpu/cpu%d/topology/core_id", core_id);

ERROR: Inappropriate bracing around statement
#75 FILE: lib/ovs-numa.c:184:
    if (access(path, F_OK) != 0)

ERROR: Inappropriate bracing around statement
#90 FILE: lib/ovs-numa.c:236:
                    if (cpu_detected(core_id))

ERROR: Inappropriate bracing around statement
#100 FILE: lib/ovs-numa.c:247:
        if (!numa_supported)

Lines checked: 237, Warnings: 2, Errors: 3


Please check this out.  If you feel there has been an error, please email aconole at redhat.com

Thanks,
0-day Robot


More information about the dev mailing list