[ovs-dev] [PATCH v2 1/2] ovs-numa: Non-consecutively numa nodes and cores

dwilder dwilder at us.ibm.com
Thu Feb 6 22:28:09 UTC 2020


On 2020-02-06 12:58, Ben Pfaff wrote:
> On Thu, Feb 06, 2020 at 12:38:16PM -0800, David Wilder wrote:
>> +    char *path;
>> +
>> +    path = xasprintf( 
>> "/sys/devices/system/cpu/cpu%d/topology/core_id" ,
>> +                     core_id);
>> +    if (access(path, F_OK) != 0) {
>> +        return 0;
>>      }
>> +
>> +    return 1;
> 
> I didn't read this whole patch, but I noticed an obvious memory leak
> here.

Thanks for the review Ben,  I will fix that in the next version.


More information about the dev mailing list