[ovs-dev] [PATCH ovn 2/2] ovn-ic: Route advertisement.

[Han Zhou]

On Fri, Feb 14, 2020 at 8:35 PM Numan Siddique <nusiddiq at redhat.com> wrote:
>
>
>
> On Sat, Feb 15, 2020, 2:36 AM Mark Michelson <mmichels at redhat.com> wrote:
>>
>> On 2/14/20 2:58 PM, Han Zhou wrote:
>> >
>> >
>> > On Fri, Feb 14, 2020 at 3:08 AM Numan Siddique <numans at ovn.org
>> > <mailto:numans at ovn.org>> wrote:
>> >  >
>> >  > On Mon, Feb 10, 2020 at 12:32 PM Han Zhou <hzhou at ovn.org
>> > <mailto:hzhou at ovn.org>> wrote:
>> >  > >
>> >  > > Support automatical route advertisement and learning for OVN
>> >  > > interconnection.  Static routes and directly connected subnets
>> >  > > can be automatically advertised to avoid manual configuration
>> >  > > across AZs.  This feature is disabled by default, and can be
>> >  > > enabled at each AZ level by:
>> >  > >
>> >  > >     ovn-nbctl set NB_Global . options:ic-route-ad=true \
>> >  >
>> >  > Hi Han,
>> >  >
>> >  > There are few checkpatch warnings. Can you please take  a look. May
>> > be its not
>> >  > possible to fix all of them.
>> >  >
>> >  > Can you please rename the option "ir-route-ad" to "ir-route-adv"
and also
>> >  > all occurrences of "route-ad" in the code to "route-adv".
>> >  >
>> >  >
>> >  > There's one comment below.
>> >  >
>> >  > With these comments addressed -
>> >  > Acked-by: Numan Siddique <numans at ovn.org <mailto:numans at ovn.org>>
>> >  >
>> >  > Thanks
>> >  > Numan
>> >  >
>> > Thanks Numan for the review. I address all comments and applied the
>> > series to master.
>> >
>> > Hi Mark, Numan and all,
>> >
>> > I know it is a little late, but I'd want to check if it is still ok to
>> > be backported to branch-20.03. I understand that normally we should
only
>> > allow bug fixes at this phase, but since the whole interconnection
>> > feature is new, I think probably it worth to backport this
>> > route-advertisement to make the interconnection feature more complete
>> > and convenient to use. Does this make sense? Nevertheless, if you think
>> > this is risky to the release schedule then please ignore this proposal
:)
>> >
>> > Thanks
>> > Han
>>
>> I'm of the opinion since ic is separated from the rest of the OVN code,
>> and because the whole thing is new, I'm ok with this being backported.
>> Anyone have a different opinion on the matter?
>
>
> I agree with Mark. I have no objection.
>
>
> Thanks
> Numan
>

Thanks Mark and Numan. I backported to branch-20.03.