[ovs-dev] [PATCH ovn] ovn-controller: Don't monitor connection table columns

[Dumitru Ceara]

On Tue, Dec 24, 2019 at 1:53 PM <numans at ovn.org> wrote:
>
> From: Numan Siddique <numans at ovn.org>
>
> ovn-controller doesn't need to know any changes to the connection
> table row. This patch omits alerts for the Connection table
> columns.
>
> In a large scale deployment like 1000 chassis, this can cause lot of
> CPU cycle wastages as ovsdb-server has to send out updates to all
> the ovn-controller connections.
>
> Signed-off-by: Numan Siddique <numans at ovn.org>

Looks good to me.

Acked-by: Dumitru Ceara <dceara at redhat.com>

Thanks,
Dumitru

> ---
>  controller/ovn-controller.c | 13 ++++++++++++-
>  1 file changed, 12 insertions(+), 1 deletion(-)
>
> diff --git a/controller/ovn-controller.c b/controller/ovn-controller.c
> index ad6dff4a2..17744d416 100644
> --- a/controller/ovn-controller.c
> +++ b/controller/ovn-controller.c
> @@ -1868,7 +1868,6 @@ main(int argc, char *argv[])
>      ovsdb_idl_omit(ovnsb_idl_loop.idl, &sbrec_sb_global_col_external_ids);
>      ovsdb_idl_omit(ovnsb_idl_loop.idl, &sbrec_logical_flow_col_external_ids);
>      ovsdb_idl_omit(ovnsb_idl_loop.idl, &sbrec_port_binding_col_external_ids);
> -    ovsdb_idl_omit(ovnsb_idl_loop.idl, &sbrec_connection_col_external_ids);
>      ovsdb_idl_omit(ovnsb_idl_loop.idl, &sbrec_ssl_col_external_ids);
>      ovsdb_idl_omit(ovnsb_idl_loop.idl,
>                     &sbrec_gateway_chassis_col_external_ids);
> @@ -1876,6 +1875,18 @@ main(int argc, char *argv[])
>      ovsdb_idl_omit(ovnsb_idl_loop.idl,
>                     &sbrec_ha_chassis_group_col_external_ids);
>
> +    /* We don't want to monitor Connection table at all. So omit all the
> +     * columns. */
> +    ovsdb_idl_omit(ovnsb_idl_loop.idl, &sbrec_connection_col_external_ids);
> +    ovsdb_idl_omit(ovnsb_idl_loop.idl, &sbrec_connection_col_inactivity_probe);
> +    ovsdb_idl_omit(ovnsb_idl_loop.idl, &sbrec_connection_col_is_connected);
> +    ovsdb_idl_omit(ovnsb_idl_loop.idl, &sbrec_connection_col_max_backoff);
> +    ovsdb_idl_omit(ovnsb_idl_loop.idl, &sbrec_connection_col_other_config);
> +    ovsdb_idl_omit(ovnsb_idl_loop.idl, &sbrec_connection_col_read_only);
> +    ovsdb_idl_omit(ovnsb_idl_loop.idl, &sbrec_connection_col_role);
> +    ovsdb_idl_omit(ovnsb_idl_loop.idl, &sbrec_connection_col_status);
> +    ovsdb_idl_omit(ovnsb_idl_loop.idl, &sbrec_connection_col_target);
> +
>      update_sb_monitors(ovnsb_idl_loop.idl, NULL, NULL, NULL);
>
>      stopwatch_create(CONTROLLER_LOOP_STOPWATCH_NAME, SW_MS);
> --
> 2.23.0
>
> _______________________________________________
> dev mailing list
> dev at openvswitch.org
> https://mail.openvswitch.org/mailman/listinfo/ovs-dev
>