[ovs-dev] [PATCH] ofproto-dpif: Fix using uninitialized execute hash.

Ilya Maximets i.maximets at ovn.org
Tue Jan 7 15:33:25 UTC 2020

On 06.01.2020 22:12, Ben Pfaff wrote:
> On Sat, Jan 04, 2020 at 12:50:34AM +0100, Ilya Maximets wrote:
>> Most of callers doesn't initialize dpif_execute.hash leaving random
>> value from the stack.  And this random value used later while encoding
>> netlink message and might produce unwanted kernel behavior.
>> Fix that by fully initializing dpif_execute structure.  Using
>> designated initializers to avoid such issues in the future.
>> Fixes: 0442bfb11d6c ("ofproto-dpif-upcall: Echo HASH attribute back to datapath.")
>> Signed-off-by: Ilya Maximets <i.maximets at ovn.org>
> Thanks so much for finding and fixing this.
> Acked-by: Ben Pfaff <blp at ovn.org>

Thanks!  Applied to master.

Best regards, Ilya Maximets.

More information about the dev mailing list