[ovs-dev] [PATCH 1/2] dpif: Turn dpif_flow_hash function into generic odp_flow_key_hash.

Ben Pfaff blp at ovn.org
Tue Jan 7 19:18:00 UTC 2020

On Sun, Dec 08, 2019 at 08:33:45PM +0100, Ilya Maximets wrote:
> Current implementation of dpif_flow_hash() doesn't depend on datapath
> interface and only complicates the callers by forcing them to figure
> out what is their current 'dpif'.  If we'll need different hashing
> for different 'dpif's we'll implement an API for dpif-providers
> and each dpif implementation will be able to use their local function
> directly without calling it via dpif API.
> This change will allow us to not store 'dpif' pointer in the userspace
> datapath implementation which is broken and will be removed in next
> commits.
> This patch moves dpif_flow_hash() to odp-util module and replaces
> unused odp_flow_key_hash() by it, along with removing of unused 'dpif'
> argument.
> Signed-off-by: Ilya Maximets <i.maximets at ovn.org>

Much nicer.

Acked-by: Ben Pfaff <blp at ovn.org>

More information about the dev mailing list