[ovs-dev] [PATCH v9 1/1] Avoid dp_hash recirculation for balance-tcp bond selection mode

Ben Pfaff blp at ovn.org
Tue Jan 7 20:42:57 UTC 2020


On Fri, Dec 20, 2019 at 11:20:10AM +0530, Vishal Deep Ajmera wrote:
> Problem:
> --------
> In OVS-DPDK, flows with output over a bond interface of type “balance-tcp”
> (using a hash on TCP/UDP 5-tuple) get translated by the ofproto layer into
> "HASH" and "RECIRC" datapath actions. After recirculation, the packet is
> forwarded to the bond member port based on 8-bits of the datapath hash
> value computed through dp_hash. This causes performance degradation in the
> following ways:

I'm not sure what's happened here but this patch really really fails to
apply:

    Applying: Avoid dp_hash recirculation for balance-tcp bond selection mode
    error: patch failed: datapath/linux/compat/include/linux/openvswitch.h:994
    error: datapath/linux/compat/include/linux/openvswitch.h: patch does not apply
    error: patch failed: lib/dpif-netdev.c:7045
    error: lib/dpif-netdev.c: patch does not apply
    error: patch failed: lib/dpif.h:905
    error: lib/dpif.h: patch does not apply
    error: patch failed: lib/odp-execute.c:990
    error: lib/odp-execute.c: patch does not apply
    error: patch failed: ofproto/ofproto-dpif-ipfix.c:3016
    error: ofproto/ofproto-dpif-ipfix.c: patch does not apply
    error: patch failed: ofproto/ofproto-dpif.c:1584
    error: ofproto/ofproto-dpif.c: patch does not apply
    error: patch failed: ofproto/ofproto-dpif.h:199
    error: ofproto/ofproto-dpif.h: patch does not apply
    Patch failed at 0001 Avoid dp_hash recirculation for balance-tcp bond selection mode
    hint: Use 'git am --show-current-patch' to see the failed patch
    When you have resolved this problem, run "git am --continue".
    If you prefer to skip this patch, run "git am --skip" instead.
    To restore the original branch and stop patching, run "git am --abort".

Maybe it needs a rebase or maybe there's something else wrong somehow.


More information about the dev mailing list