[ovs-dev] [PATCH] compat: Include confirm_neigh parameter if needed

[Simon Horman]

On Tue, Jan 07, 2020 at 08:35:57AM -0800, Gregory Rose wrote:
> On 1/7/2020 1:34 AM, Simon Horman wrote:
> > On Mon, Jan 06, 2020 at 01:36:34PM -0800, Greg Rose wrote:

...

> > > --- a/datapath/linux/compat/ip6_gre.c
> > > +++ b/datapath/linux/compat/ip6_gre.c
> > > @@ -1089,7 +1089,11 @@ static netdev_tx_t ip6erspan_tunnel_xmit(struct sk_buff *skb,
> > >   	/* TooBig packet may have updated dst->dev's mtu */
> > >   	if (!t->parms.collect_md && dst && dst_mtu(dst) > dst->dev->mtu)
> > > +#ifndef HAVE_DST_OPS_CONFIRM_NEIGH
> > >   		dst->ops->update_pmtu(dst, NULL, skb, dst->dev->mtu);
> > > +#else
> > > +		dst->ops->update_pmtu(dst, NULL, skb, dst->dev->mtu, false);
> > > +#endif
> > Did you consider using skb_dst_update_pmtu() unconditionally?
> > That may be cleaner going forwards.
> 
> Yes, but it defaults to true for the boolean parameter to confirm the
> neighbor entry
> and I didn't want to change behavior for older kernels.  If you think that's
> not a concern
> then I'd be happy to respin the patch using skb_dst_update_pmtu().

Thanks Greg,

after reviewing things another time I agree that what you have done is
correct.