[ovs-dev] [PATCH] dpif-netdev: Allow to set max capacity of flow on netdev

Tonghao Zhang xiangxia.m.yue at gmail.com
Wed Jan 8 09:36:47 UTC 2020


On Wed, Jan 8, 2020 at 6:34 AM Ben Pfaff <blp at ovn.org> wrote:
>
> On Mon, Dec 23, 2019 at 07:17:34PM +0800, xiangxia.m.yue at gmail.com wrote:
> > From: Tonghao Zhang <xiangxia.m.yue at gmail.com>
> >
> > There may be too many flows (> MAX_FLOWS 65536) on
> > dpif-netdev at same time. For this case, we support
> > the ovs-appctl command to change the flow max number.
> >
> > Signed-off-by: Tonghao Zhang <xiangxia.m.yue at gmail.com>
>
> Thanks for the patch.
>
> I think that netdev_max_flows should be an atomic_uint32_t because it is
> accessed from multiple threads.
>
> Usually the replies to appctl commands are very terse, so that a
> successful reply to change a value would just be empty and the reply for
> getting a value would just be the raw value, and usually we don't
> include a new-line at the end.
v2 is sent, pls help me review this patch:
http://patchwork.ozlabs.org/patch/1219494/

Thanks.
> Thanks,
>
> Ben.


More information about the dev mailing list