[ovs-dev] [PATCH] odp-util: Fix passing uninitialized bytes in OVS_KEY_ATTR_CT_ORIG_TUPLE_IPV*.

Ilya Maximets i.maximets at ovn.org
Mon Jan 13 17:55:29 UTC 2020


On 09.01.2020 19:16, Ben Pfaff wrote:
> On Thu, Jan 09, 2020 at 05:27:36PM +0100, Ilya Maximets wrote:
>> Both ovs_key_ct_tuple_ipv* structures contains padding at the end
>> that mast be cleared before passing attributes to kernel:
> 
> Good catch.
> 
> I think that you could save a line for the memset() call by using
> nl_msg_put_unspec_zero().
> 
> Acked-by: Ben Pfaff <blp at ovn.org>
> 

Thanks!  I updated this patch to use nl_msg_put_unspec_zero().
Applied to master and backported.

Best regards, Ilya Maximets.


More information about the dev mailing list