[ovs-dev] [PATCH v2] tc: handle packet mark of zero

Simon Horman simon.horman at netronome.com
Tue Jan 21 14:42:47 UTC 2020


On Thu, Jan 16, 2020 at 09:23:11AM -0500, Aaron Conole wrote:
> Simon Horman <simon.horman at netronome.com> writes:
> 
> > On Thu, Jan 16, 2020 at 04:59:54AM -0500, 0-day Robot wrote:
> >> Bleep bloop.  Greetings Simon Horman, I am a robot and I have tried out your patch.
> >> Thanks for your contribution.
> >> 
> >> I encountered some error that I wasn't expecting.  See the details below.
> >> 
> >> 
> >> checkpatch:
> >> WARNING: Unexpected sign-offs from developers who are not authors or
> >> co-authors or committers: Simon Horman <simon.horman at netronome.com>
> >> Lines checked: 44, Warnings: 1, Errors: 0
> >
> > Is the correct tag Co-Authored-by rather than Co-Authored as used in
> > this patch?
> 
> Yes.
> 
> Co-authored-by
> 
> Not sure if we should make the tags a bit more lenient, but that's a
> separate discussion. :)

On Thu, Jan 16, 2020 at 11:35:54AM -0800, Ben Pfaff wrote:
> On Thu, Jan 16, 2020 at 11:20:20AM +0100, Simon Horman wrote:
> > On Thu, Jan 16, 2020 at 04:59:54AM -0500, 0-day Robot wrote:
> > > Bleep bloop.  Greetings Simon Horman, I am a robot and I have tried out your patch.
> > > Thanks for your contribution.
> > > 
> > > I encountered some error that I wasn't expecting.  See the details below.
> > > 
> > > 
> > > checkpatch:
> > > WARNING: Unexpected sign-offs from developers who are not authors or co-authors or committers: Simon Horman <simon.horman at netronome.com>
> > > Lines checked: 44, Warnings: 1, Errors: 0
> > 
> > Is the correct tag Co-Authored-by rather than Co-Authored as used in
> > this patch?
> 
> Yes, it should be Co-authored-by.  See
> Documentation/internals/contributing/submitting-patches.rst

Thanks. Fixing up the tag seems easy enough.  But I'd appreciate some
feedback on if people are happy with me applying this change or not.


More information about the dev mailing list