[ovs-dev] [PATCH v2] tc: handle packet mark of zero

Simon Horman simon.horman at netronome.com
Wed Jan 22 13:22:09 UTC 2020


On Wed, Jan 22, 2020 at 03:25:06AM -0500, Aaron Conole wrote:
> Simon Horman <simon.horman at netronome.com> writes:
> 
> > From: John Hurley <john.hurley at netronome.com>
> >
> > Openstack may set an skb mark of 0 in tunnel rules. This is considered to
> > be an unused/unset value. However, it prevents the rule from being
> > offloaded.
> >
> > Check if the key value of the skb mark is 0 when it is in use (mask is
> > set to all ones). If it is then ignore the field and continue with TC offload.
> >
> > Only the exact-match case is covered by this patch as it addresses the
> > Openstack use-case and seems most robust against feature evolution: f.e. in
> > future there may exist hardware offload scenarios where an operation, such
> > as a BPF offload, sets the SKB mark before proceeding tho the in-HW OVS.
> > datapath.
> >
> > Signed-off-by: John Hurley <john.hurley at netronome.com>
> > Co-Authored: Simon Horman <simon.horman at netronome.com>
> > Signed-off-by: Simon Horman <simon.horman at netronome.com>
> >
> > ---
> 
> With the change to the Co-Authored tag:
> 
> Acked-by: Aaron Conole <aconole at redhat.com>

Thanks, pushed to master.

My feeling is that this is a fix and appropriate for backporting.
Do you have any thoughts on that?


More information about the dev mailing list