[ovs-dev] [PATCH 3/3] ovn-controller.c: Support option "ovn-monitor-all".

Han Zhou hzhou at ovn.org
Sat Jan 25 00:48:41 UTC 2020


On Fri, Jan 24, 2020 at 11:08 AM Numan Siddique <numans at ovn.org> wrote:
>
>
>
> On Fri, Jan 24, 2020, 21:38 Han Zhou <hzhou at ovn.org> wrote:
>>
>> On Fri, Jan 24, 2020 at 1:24 AM Numan Siddique <numans at ovn.org> wrote:
>> >
>> > On Tue, Jan 14, 2020 at 4:22 AM Han Zhou <hzhou at ovn.org> wrote:
>> > >
>> > > Set this option to true will avoid using conditional monitoring in
>> > > ovn-controller.  Setting it to true helps in environments where
>> > > all (or most) workloads need to be reachable from each other, thus
>> > > the effectiveness of conditional monitoring is low, but the overhead
>> > > of conditional monitoring is high.
>> > >
>> > > Requested-by: Girish Moodalbail <gmoodalbail at nvidia.com>
>> > > Signed-off-by: Han Zhou <hzhou at ovn.org>
>> >
>> > Hi Han,
>> >
>> > I am curious what happens when this option is toggled from true to
false ?
>>
>> Hi, Numan,
>>
>> Thanks for the review. Please see my response below.
>>
>> If toggle from true to false, the monitor condition will be updated to
>> monitor only the interested rows whenever there is a change triggered in
>> engine node runtime_data:
>>                           if (engine_node_changed(&en_runtime_data)) {
>>                               update_sb_monitors(ovnsb_idl_loop.idl,
>> chassis,
>> ...
>
>
> Thanks for the response.
>
> Acked-by: Numan Siddique <numans at ovn.org>
>
> Numan
>
>>
Thanks Numan. I applied this to master.


More information about the dev mailing list