[ovs-dev] [PATCH ovn] ovn-northd: Fix uninitialized 'prefix' in 'ip46_parse_cidr'.

[Han Zhou]

On Mon, Jan 27, 2020 at 11:52 PM Dumitru Ceara <dceara at redhat.com> wrote:
>
> On 1/28/20 7:31 AM, Numan Siddique wrote:
> > On Tue, Jan 28, 2020 at 7:55 AM Han Zhou <hzhou at ovn.org> wrote:
> >>
> >> On Mon, Jan 27, 2020 at 6:32 AM Dumitru Ceara <dceara at redhat.com>
wrote:
> >>>
> >>> On 1/27/20 3:07 PM, Numan Siddique wrote:
> >>>> On Mon, Jan 27, 2020 at 6:35 PM Dumitru Ceara <dceara at redhat.com>
wrote:
> >>>>>
> >>>>> The partially initialized 'prefix' was later used for computing
route
> >>>>> hashes (route_hash()) causing the ECMP routes to be incorrectly
> >>>>> installed. To fix the issue we now zero out the prefix before
parsing
> >>>>> it.
> >>>>>
> >>>>> CC: Han Zhou <hzhou at ovn.org>
> >>>>> Fixes: 4e53974bdc4e ("ovn-northd: Support ECMP routes.")
> >>>>> Signed-off-by: Dumitru Ceara <dceara at redhat.com>
> >>>>
> >>>> Thanks Dumitru for the fix. I applied this to master.
> >>>>
> >>>> Numan
> >>>>
> >>>
> >>> Thanks Numan!
> >>>
> >> Thanks for fixing this and sorry for the trouble!
> >> Dumitru, I am just curious - did the test case just fail on your
computer
> >> or how did you find the problem?
> >
> > In my test, test cases never failed. It even passed in travis CI.
> >
> > Thanks
> > Numan
> >
>
> On my machine the ECMP test was failing 100% of the time due to hash
> mismatches.
>
> Regards,
> Dumitru
>

I see, thank you (and your machine :))!