[ovs-dev] [PATCH ovn v4 02/13] ovn-ic-nb: Interconnection northbound DB schema and CLI.

Wed Jan 29 21:02:40 UTC 2020

Bleep bloop.  Greetings Han Zhou, I am a robot and I have tried out your patch.
Thanks for your contribution.

I encountered some error that I wasn't expecting.  See the details below.

checkpatch:
WARNING: Line is 85 characters long (recommended limit is 79)
#346 FILE: ovn-ic-nb.xml:35:
      Northbound configuration for OVN interconnection.  This table must have exactly

WARNING: Line is 80 characters long (recommended limit is 79)
#378 FILE: ovn-ic-nb.xml:67:
      Each row represents one transit logical switch for interconnection between

WARNING: Line is 82 characters long (recommended limit is 79)
#470 FILE: ovn-ic-nb.xml:159:
          <dt><code>ssl:<var>host</var></code>[<code>:<var>port</var></code>]</dt>

WARNING: Line is 81 characters long (recommended limit is 79)
#477 FILE: ovn-ic-nb.xml:166:
              specified via command-line options or the <ref table="SSL"/> table.

WARNING: Line is 82 characters long (recommended limit is 79)
#488 FILE: ovn-ic-nb.xml:177:
          <dt><code>tcp:<var>host</var></code>[<code>:<var>port</var></code>]</dt>

WARNING: Line is 84 characters long (recommended limit is 79)
#494 FILE: ovn-ic-nb.xml:183:
              address, wrap it in square brackets, e.g. <code>tcp:[::1]:6640</code>.

WARNING: Line is 85 characters long (recommended limit is 79)
#500 FILE: ovn-ic-nb.xml:189:
          <dt><code>pssl:</code>[<var>port</var>][<code>:<var>host</var></code>]</dt>

WARNING: Line is 80 characters long (recommended limit is 79)
#512 FILE: ovn-ic-nb.xml:201:
              A valid SSL configuration must be provided when this form is used,

WARNING: Line is 85 characters long (recommended limit is 79)
#524 FILE: ovn-ic-nb.xml:213:
          <dt><code>ptcp:</code>[<var>port</var>][<code>:<var>host</var></code>]</dt>

WARNING: Line is 110 characters long (recommended limit is 79)
#599 FILE: ovn-ic-nb.xml:288:
              type='{"type": "string", "enum": ["set", ["VOID", "BACKOFF", "CONNECTING", "ACTIVE", "IDLE"]]}'>

WARNING: Line is 96 characters long (recommended limit is 79)
#848 FILE: utilities/ovn-ic-nbctl.8.xml:4:
    <p>ovn-ic-nbctl -- Open Virtual Network interconnection northbound db management utility</p>

WARNING: Line is 96 characters long (recommended limit is 79)
#851 FILE: utilities/ovn-ic-nbctl.8.xml:7:
    <p><code>ovn-ic-nbctl</code> [<var>options</var>] <var>command</var> [<var>arg</var>...]</p>

WARNING: Line is 90 characters long (recommended limit is 79)
#854 FILE: utilities/ovn-ic-nbctl.8.xml:10:
    <p>This utility can be used to manage the OVN interconnection northbound database.</p>

WARNING: Line is 81 characters long (recommended limit is 79)
#900 FILE: utilities/ovn-ic-nbctl.8.xml:56:
    <p>These commands query and modify the contents of <code>ovsdb</code> tables.

WARNING: Line is 92 characters long (recommended limit is 79)
#902 FILE: utilities/ovn-ic-nbctl.8.xml:58:
    as such they operate at a lower level than other <code>ovn-ic-nbctl</code> commands.</p>

WARNING: Line is 82 characters long (recommended limit is 79)
#904 FILE: utilities/ovn-ic-nbctl.8.xml:60:
    <p>Each of these commands has a <var>table</var> parameter to identify a table

WARNING: Line is 87 characters long (recommended limit is 79)
#928 FILE: utilities/ovn-ic-nbctl.8.xml:84:
    <xi:include href="lib/db-ctl-base.xml" xmlns:xi="http://www.w3.org/2003/XInclude"/>

WARNING: Line is 114 characters long (recommended limit is 79)
#942 FILE: utilities/ovn-ic-nbctl.8.xml:98:
      <dt>[<code>--inactivity-probe=</code><var>msecs</var>] <code>set-connection</code> <var>target</var>...</dt>

WARNING: Line is 80 characters long (recommended limit is 79)
#945 FILE: utilities/ovn-ic-nbctl.8.xml:101:
        <code>--inactivity-probe=</code><var>msecs</var> to override the default

WARNING: Line is 83 characters long (recommended limit is 79)
#946 FILE: utilities/ovn-ic-nbctl.8.xml:102:
        idle connection inactivity probe time.  Use 0 to disable inactivity probes.

WARNING: Line is 86 characters long (recommended limit is 79)
#977 FILE: utilities/ovn-ic-nbctl.8.xml:133:
      Otherwise, the default is <code>unix:@RUNDIR@/ovn_ic_nb_db.sock</code>, but this

WARNING: Line is 81 characters long (recommended limit is 79)
#986 FILE: utilities/ovn-ic-nbctl.8.xml:142:
      is a clustered database, <code>ovn-ic-nbctl</code> will avoid servers other

WARNING: Line is 82 characters long (recommended limit is 79)
#989 FILE: utilities/ovn-ic-nbctl.8.xml:145:
      <code>--no-leader-only</code>, <code>ovn-ic-nbctl</code> will use any server

WARNING: Line is 80 characters long (recommended limit is 79)
#999 FILE: utilities/ovn-ic-nbctl.8.xml:155:
    <xi:include href="lib/vlog.xml" xmlns:xi="http://www.w3.org/2003/XInclude"/>

WARNING: Line is 81 characters long (recommended limit is 79)
#1004 FILE: utilities/ovn-ic-nbctl.8.xml:160:
    <xi:include href="lib/table.xml" xmlns:xi="http://www.w3.org/2003/XInclude"/>

WARNING: Line is 89 characters long (recommended limit is 79)
#1012 FILE: utilities/ovn-ic-nbctl.8.xml:168:
    <xi:include href="lib/ssl-bootstrap.xml" xmlns:xi="http://www.w3.org/2003/XInclude"/>

WARNING: Line is 82 characters long (recommended limit is 79)
#1016 FILE: utilities/ovn-ic-nbctl.8.xml:172:
    <xi:include href="lib/common.xml" xmlns:xi="http://www.w3.org/2003/XInclude"/>

WARNING: Line lacks whitespace around operator
#1330 FILE: utilities/ovn-ic-nbctl.c:306:
  ts-add SWITCH              create a transit switch named SWITCH\n\

WARNING: Line lacks whitespace around operator
#1331 FILE: utilities/ovn-ic-nbctl.c:307:
  ts-del SWITCH              delete SWITCH\n\

WARNING: Line lacks whitespace around operator
#1332 FILE: utilities/ovn-ic-nbctl.c:308:
  ts-list                    print all transit switches\n\

WARNING: Line lacks whitespace around operator
#1335 FILE: utilities/ovn-ic-nbctl.c:311:
  get-connection             print the connections\n\

WARNING: Line lacks whitespace around operator
#1336 FILE: utilities/ovn-ic-nbctl.c:312:
  del-connection             delete the connections\n\

WARNING: Line lacks whitespace around operator
WARNING: Line lacks whitespace around operator
WARNING: Line lacks whitespace around operator
#1337 FILE: utilities/ovn-ic-nbctl.c:313:
  [--inactivity-probe=MSECS]\n\

WARNING: Line lacks whitespace around operator
#1338 FILE: utilities/ovn-ic-nbctl.c:314:
  set-connection TARGET...   set the list of connections to TARGET...\n\

WARNING: Line lacks whitespace around operator
#1341 FILE: utilities/ovn-ic-nbctl.c:317:
  get-ssl                     print the SSL configuration\n\

WARNING: Line lacks whitespace around operator
#1342 FILE: utilities/ovn-ic-nbctl.c:318:
  del-ssl                     delete the SSL configuration\n\

WARNING: Line lacks whitespace around operator
#1343 FILE: utilities/ovn-ic-nbctl.c:319:
  set-ssl PRIV-KEY CERT CA-CERT [SSL-PROTOS [SSL-CIPHERS]] \

WARNING: Line lacks whitespace around operator
WARNING: Line lacks whitespace around operator
#1350 FILE: utilities/ovn-ic-nbctl.c:326:
  --db=DATABASE               connect to DATABASE\n\

WARNING: Line lacks whitespace around operator
#1352 FILE: utilities/ovn-ic-nbctl.c:328:
  --no-leader-only            accept any cluster member, not just the leader\n\

WARNING: Line lacks whitespace around operator
WARNING: Line lacks whitespace around operator
#1353 FILE: utilities/ovn-ic-nbctl.c:329:
  -t, --timeout=SECS          wait at most SECS seconds\n\

WARNING: Line lacks whitespace around operator
#1354 FILE: utilities/ovn-ic-nbctl.c:330:
  --dry-run                   do not commit changes to database\n\

WARNING: Line lacks whitespace around operator
WARNING: Line lacks whitespace around operator
WARNING: Line lacks whitespace around operator
#1361 FILE: utilities/ovn-ic-nbctl.c:337:
  --no-syslog             equivalent to --verbose=ic_nbctl:syslog:warn\n");

WARNING: Comment with 'xxx' marker
#1781 FILE: utilities/ovn-ic-nbctl.c:757:
        /* XXX add verification that table is empty */

WARNING: Line is 81 characters long (recommended limit is 79)
#1948 FILE: utilities/ovn-ic-nbctl.c:924:
    { "ts-add", 1, 1, "SWITCH", NULL, ic_nbctl_ts_add, NULL, "--may-exist", RW },

WARNING: Line is 81 characters long (recommended limit is 79)
#1949 FILE: utilities/ovn-ic-nbctl.c:925:
    { "ts-del", 1, 1, "SWITCH", NULL, ic_nbctl_ts_del, NULL, "--if-exists", RW },

Lines checked: 1980, Warnings: 51, Errors: 0

Please check this out.  If you feel there has been an error, please email aconole at redhat.com

Thanks,
0-day Robot