[ovs-dev] [PATCH 1/1] flow: Fix parsing l3_ofs with partial offloading

Ilya Maximets i.maximets at ovn.org
Thu Jan 30 11:28:39 UTC 2020


On 14.01.2020 14:21, Eli Britstein wrote:
> l3_ofs should be set all Ethernet packets, not just IPv4/IPv6 ones.
> For example for ARP over VLAN tagged packets, it may cause wrong
> processing like in changing the VLAN ID action. Fix it.
> 
> Fixes: aab96ec4d81e ("dpif-netdev: retrieve flow directly from the flow mark")
> Signed-off-by: Eli Britstein <elibr at mellanox.com>
> Reviewed-by: Roi Dayan <roid at mellanox.com>
> ---

Thanks, Eli.  This seems correct to me.  I'm traveling now, will be able
to check on next week if Ben will not get to this earlier.

BTW, it might be good to have a unit test for this.  We already have
a couple of such partial offloading tests.

Best regards, Ilya Maximets.


More information about the dev mailing list