[ovs-dev] [PATCH] dpdk: Refuse running on cpu >= RTE_MAX_LCORE.

[David Marchand]

On Thu, Jul 2, 2020 at 5:53 PM Ilya Maximets <i.maximets at ovn.org> wrote:
> > pmd threads will never run on any core >= RTE_MAX_LCORE ok, it works.
> >
> > Though, it binds OVS core id and DPDK lcore id.
> > Should OVS really care about this?
>
> I think this is better than random abort() in production environment.
> And, in current code, OVS cores bound to lcores as 1 to 1.

Yes, I did not like either the abort(), I added it wrt to a comment from Kevin.
But rereading it, I might have misunderstood.


>
> I understand that there will be no direct binding with the new
> rte_thread_register API, and we will need to figure out how to work
> with it correctly.  With new API above changes will need to be reverted
> and some new handling introduced to limit total number of cores, not
> their IDs.  Maybe something like this (not tested):

I just wanted to make sure you had the other patch in mind.
I'll have a try with your proposal.

Thanks.

-- 
David Marchand