[ovs-dev] [PATCH v4 ovn 0/5] Reduce number of flows in IN_IP_INPUT table for DNAT.

Dumitru Ceara dceara at redhat.com
Fri Jul 3 18:33:27 UTC 2020


Patch 1 documents and refactors the usage of OVS registers in logical
flows.

Patches 2-4 refactor the ARP/NS responder code for logical routers in
order to make it easier for patch 5 to configure the flows with different
priorities depending on logical port type.

Suggested-by: Han Zhou <hzhou at ovn.org>
Reported-by: Girish Moodalbail <gmoodalbail at gmail.com>
Reported-at: https://mail.openvswitch.org/pipermail/ovs-discuss/2020-June/050186.html
Signed-off-by: Dumitru Ceara <dceara at redhat.com>

Dumitru Ceara (5):
      ovn-northd: Document OVS register usage in logical flows.
      ovn-northd: Store ETH address of router inport in xreg0.
      ovn-northd: Refactor ARP/NS responder in router pipeline.
      ovn-northd: Refactor NAT address parsing.
      ovn-northd: Minimize number of ARP/NS responder flows for DNAT.


 northd/ovn-northd.8.xml |   46 ++-
 northd/ovn-northd.c     |  829 +++++++++++++++++++++++++++++------------------
 tests/ovn-northd.at     |  149 ++++++++
 tests/ovn.at            |    8 
 4 files changed, 684 insertions(+), 348 deletions(-)


---
v4:
- Addressed Han's comments:
  - Patch 1: mentioned pipeline stages where R0 and R1 are used.
  - Patch 5: simplified drop flows for DNAT ARP resolver (prio 91).
  - Patch 5: run the loop for DNAT ARP resolver flow generation twice,
    once for SNAT, once for DNAT.
- Added Han's acks on patches 2-4.
- Patch 4: Coding style: fix function definition.
v3:
- Addressed Han's comment:
  - fixed register diagram in patch 1 and 2.
  - added Han's ack on patch 1.
v2:
- Addressed Numan's comments:
  - Inserted a new patch in the beginning of the series to document
    OVS register usage in logical flows. Also refactored the code
    to avoid using bare register names.
  - Added unit tests to ovn-northd.at in every patch that changed
    logical flows.
  - Added/updated documentation in ovn-northd.8.xml in every patch that
    changed logical flows.



More information about the dev mailing list