[ovs-dev] [PATCH v8] ovsdb-idl: Force IDL retry when missing updates encountered.

Dumitru Ceara dceara at redhat.com
Tue Jul 7 15:06:33 UTC 2020


On 7/7/20 1:01 PM, Ilya Maximets wrote:
> On 7/2/20 4:20 PM, Dumitru Ceara wrote:
>> Adds a generic recovery mechanism which triggers an IDL retry with fast
>> resync disabled in case the IDL has detected that it ended up in an
>> inconsistent state due to other bugs in the ovsdb-server/ovsdb-idl
>> implementation.
>>
>> Additionally, this commit also:
>> - bumps IDL semantic error logs to level ERR to make them more
>>   visible.
>> - triggers an IDL retry in cases when the IDL client used to try to
>>   recover (i.e., trying to add an existing row, trying to remove a non
>>   existent row).
>>
>> CC: Andy Zhou <azhou at ovn.org>
>> CC: Han Zhou <hzhou at ovn.org>
>> CC: Ilya Maximets <i.maximets at ovn.org>
>> Fixes: db2b5757328c ("lib: add monitor2 support in ovsdb-idl.")
>> Acked-by: Han Zhou <hzhou at ovn.org>
>> Signed-off-by: Dumitru Ceara <dceara at redhat.com>
>>
>> ---
> 
> Thanks, Dumitru and Han!  Applied.
> 
> I'm not sure about backporting this as it looks more like a new feature
> than a bugfix.  Thoughts?
> 
> Best regards, Ilya Maximets.
> 

Thanks Ilya!

I'll let Han comment on the backport question because he requested this
new version of the patch and I'm not sure whether waiting for OVS2.14 is
an option or not.

Regards,
Dumitru



More information about the dev mailing list