[ovs-dev] [PATCH v5] system-dpdk: add negotiation check for userspace-tso

[Gowrishankar Muthukrishnan]

On Tue, Jul 7, 2020 at 7:19 PM Flavio Leitner <fbl at sysclose.org> wrote:

>
> Hi Gowrishankar,
>
> Thanks for following up with this patch.
>
> However, I think we need to reconsider the tests. It doesn't seem
> useful to have negotiation tests that will always fail because of
> a code that is marked as deprecated (vhost-user).
>
> I see few options here:
>
> 1) Fix vhost-user to support TSO.
>    I reviewed the code and that negotiation patch I posted before
>    fixing the negotiation is not enough. Well, I don't think we
>    should spend time fixing deprecated code at this point.
>
> 2) Split the vhost-user client and vhost-user tests.
>    That would be better because we would know if something we care
>    about (vhost-user client) is broken or not. But having a hopeless
>    test that always fail makes it hard to automate, etc...
>
> 3) Split and fix the tests to check if the negotiation actually happened
>    as we expect today. So, vhost-user client test check if the TSO bits
>    are there while vhost-user test check if the TSO bits are _not_ there.
>
> 4) Remove testing of vhost-user server since that is deprecated and
>    most probably will be removed soon.
>
>
> I think the #3 option is the best one at the moment, but #4 would be
> acceptable in my opinion as well.
>
>
Ack Flavio. Posted v6 based on this with a couple of additional tests as in
sample logs shown.

Thanks for the suggestion.


> What do you think?
>
> Thanks
> fbl
>

-- 
Gowrishankar M