[ovs-dev] [PATCH V6 00/12] netdev datapath offload: Support IPv6 and VXLAN encap

Ilya Maximets i.maximets at ovn.org
Thu Jul 9 22:38:10 UTC 2020


On 7/8/20 7:22 PM, Ilya Maximets wrote:
> On 7/8/20 8:38 AM, Eli Britstein wrote:
>> This patch set includes enhanced logging to increase debugability, bug
>> fixes and additional offloads - IPv6 and VXLAN encap.
>>
>> Patches #1-#2:  Enhance log prints for debugability.
>> Patches #3-#4:  Bug fixes for partial offloads and Ethernet matching.
>> Patches #5-#12: Add support for offloads of IPv6 patterns, partial
>>                 TCP/UDP ports, set IPv6 and encap actions
>>                 (clone/output).
>>
>> v2-v1:
>> - Removed redundant out label.
>> - Added a patch to fix dl_type match only.
>> v3-v2:
>> - Rebased, and more elaboration in #7 commit message.
>> v4-v3:
>> - Rebased, changed order of commits.
>> - Testpmd format replaces pervious format.
>> - Some comments from Ilya/Harsha addressed.
>> v5-v4:
>> - Removed redundant trailing '\n' from log messages.
>> - Removed 'testpmd' keyword.
>> - 'DUMP_TESTPMD_ITEM' -> 'DUMP_PATTERN_ITEM'.
>> - Removed *_mask1 variables.
>> - Changed logging to dynamic string for tunnel dumps.
>> v6-v5:
>> - Not introducing/removing 'testpmd' keyword.
>> - Minor log format fixes.
>>
>> Travis:
>> v1: https://travis-ci.org/github/elibritstein/OVS/builds/688413350
>> v2: https://travis-ci.org/github/elibritstein/OVS/builds/691375847
>> v3: https://travis-ci.org/github/elibritstein/OVS/builds/700534550
>> v4: https://travis-ci.org/github/elibritstein/OVS/builds/703556030
>> v5: https://travis-ci.org/github/elibritstein/OVS/builds/705679636
>> v6: https://travis-ci.org/github/elibritstein/OVS/builds/706044892
>>
>> Eli Britstein (10):
>>   netdev-offload-dpdk: Log testpmd format for flow create/destroy
>>   dpif-netdev: Add mega ufid in flow add/del log
>>   dpif-netdev: Don't use zero flow mark
>>   netdev-offload-dpdk: Fix Ethernet matching for type only
>>   netdev-offload-dpdk: Support partial TCP/UDP port matching
>>   netdev-offload-dpdk: Remove pre-validate of patterns function
>>   netdev-offload-dpdk: Add IPv6 pattern matching
>>   netdev-offload-dpdk: Support offload of set IPv6 actions
>>   netdev-offload-dpdk: Support offload of clone tnl_push/output actions
>>   netdev-offload-dpdk: Support tnl/push using vxlan encap attribute
>>
>> Ilya Maximets (2):
>>   netdev: Allow storing dpif type into netdev structure.
>>   netdev-offload: Use dpif type instead of class.
>>
>>  Documentation/howto/dpdk.rst  |   4 +-
>>  NEWS                          |   3 +
>>  lib/dpif-netdev.c             |  36 +-
>>  lib/dpif-netlink.c            |  23 +-
>>  lib/dpif.c                    |  21 +-
>>  lib/netdev-offload-dpdk.c     | 883 ++++++++++++++++++++++++++----------------
>>  lib/netdev-offload-tc.c       |   3 +-
>>  lib/netdev-offload.c          |  52 ++-
>>  lib/netdev-offload.h          |  16 +-
>>  lib/netdev-provider.h         |   3 +-
>>  lib/netdev.c                  |  16 +
>>  lib/netdev.h                  |   2 +
>>  ofproto/ofproto-dpif-upcall.c |   5 +-
>>  tests/dpif-netdev.at          |  20 +-
>>  tests/ofproto-macros.at       |   3 +-
>>  15 files changed, 680 insertions(+), 410 deletions(-)
>>
> 
> Thanks!
> 
> I fixed the NEWS line in patch #8 as "IPv6 TCP/UDP ports" doesn't sound
> correct to me and also stripped line breaks from VLOG in patch #2.
> With that, applied to master branch.

I also backported patches #3 and #4 down to 2.10.

Best regards, Ilya Maximets.


More information about the dev mailing list