[ovs-dev] [PATCH 1/3] netdev-offload-dpdk: Set transfer attribute to zero for mark/rss offload

Eli Britstein elibr at mellanox.com
Mon Jul 13 07:37:10 UTC 2020


On 7/10/2020 3:07 PM, Sriharsha Basavapatna wrote:
> The offload layer doesn't initialize the 'transfer' attribute
> for mark/rss offload (partial offload). It should be set to 0.
>
> Fixes: 60e778c7533a ("netdev-offload-dpdk: Framework for actions offload.")

It is not a bug. .ingress = 1 is also sufficient.

See 
http://www.gnu.org/software/gnu-c-manual/gnu-c-manual.html#Initializing-Structure-Members

Anyway, this is the commit that introduced it.

e8a2b5bf92bb ("netdev-dpdk: implement flow offload with rte flow")

> Signed-off-by: Sriharsha Basavapatna <sriharsha.basavapatna at broadcom.com>
> ---
>   lib/netdev-offload-dpdk.c | 3 ++-
>   1 file changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/lib/netdev-offload-dpdk.c b/lib/netdev-offload-dpdk.c
> index 26a75f0f2..4c652fd82 100644
> --- a/lib/netdev-offload-dpdk.c
> +++ b/lib/netdev-offload-dpdk.c
> @@ -818,7 +818,8 @@ netdev_offload_dpdk_mark_rss(struct flow_patterns *patterns,
>           .group = 0,
>           .priority = 0,
>           .ingress = 1,
> -        .egress = 0
> +        .egress = 0,
> +        .transfer = 0
>       };
>       struct rte_flow_error error;
>       struct rte_flow *flow;


More information about the dev mailing list