[ovs-dev] [PATCH v2 1/1] dpdk: Use DPDK 19.11.2 release.

Mon Jul 13 10:17:13 UTC 2020

On 7/13/2020 10:44 AM, Ilya Maximets wrote:
> On 7/11/20 2:34 PM, Ian Stokes wrote:
>> Modify travis linux build script to use DPDK 19.11.2 stable release and
>> update docs to reference 19.11.2 stable release.
>>
>> Signed-off-by: Ian Stokes <ian.stokes at intel.com>
>> ---
>>   .travis/linux-build.sh                   | 2 +-
>>   Documentation/faq/releases.rst           | 2 +-
>>   Documentation/intro/install/dpdk.rst     | 8 ++++----
>>   Documentation/topics/dpdk/vhost-user.rst | 6 +++---
>>   Documentation/topics/userspace-tso.rst   | 9 ---------
>>   NEWS                                     | 3 +++
>>   6 files changed, 12 insertions(+), 18 deletions(-)
>>
>> diff --git a/.travis/linux-build.sh b/.travis/linux-build.sh
>> index 02615a8ec..e0a065291 100755
>> --- a/.travis/linux-build.sh
>> +++ b/.travis/linux-build.sh
>> @@ -170,7 +170,7 @@ fi
>>   
>>   if [ "$DPDK" ] || [ "$DPDK_SHARED" ]; then
>>       if [ -z "$DPDK_VER" ]; then
>> -        DPDK_VER="19.11"
>> +        DPDK_VER="19.11.2"
>>       fi
>>       install_dpdk $DPDK_VER
>>       if [ "$CC" = "clang" ]; then
>> diff --git a/Documentation/faq/releases.rst b/Documentation/faq/releases.rst
>> index e5cef3915..7c826f239 100644
>> --- a/Documentation/faq/releases.rst
>> +++ b/Documentation/faq/releases.rst
>> @@ -194,7 +194,7 @@ Q: What DPDK version does each Open vSwitch release work with?
>>       2.10.x       17.11.4
>>       2.11.x       18.11.6
>>       2.12.x       18.11.6
>> -    2.13.x       19.11.0
>> +    2.13.x       19.11.2
> 
> We likely need to update versions for older branches too.
> Might be done with a separate patch.  We need to maintain
> this list at least on master branch since we have it in
> documentation.

Sure, happy to update it in this patch, I've  sent DPDK updates for 
branches 2.9 - 2.13. I can wait for them to be approve before updating here?

BR
Ian
> 
>>       ============ =======
>>   
>>   Q: Are all the DPDK releases that OVS versions work with maintained?
>> diff --git a/Documentation/intro/install/dpdk.rst b/Documentation/intro/install/dpdk.rst
>> index dbf88ec43..90eaa8aa2 100644
>> --- a/Documentation/intro/install/dpdk.rst
>> +++ b/Documentation/intro/install/dpdk.rst
>> @@ -42,7 +42,7 @@ Build requirements
>>   In addition to the requirements described in :doc:`general`, building Open
>>   vSwitch with DPDK will require the following:
>>   
>> -- DPDK 19.11
>> +- DPDK 19.11.2
>>   
>>   - A `DPDK supported NIC`_
>>   
>> @@ -71,9 +71,9 @@ Install DPDK
>>   #. Download the `DPDK sources`_, extract the file and set ``DPDK_DIR``::
>>   
>>          $ cd /usr/src/
>> -       $ wget https://fast.dpdk.org/rel/dpdk-19.11.tar.xz
>> -       $ tar xf dpdk-19.11.tar.xz
>> -       $ export DPDK_DIR=/usr/src/dpdk-19.11
>> +       $ wget https://fast.dpdk.org/rel/dpdk-19.11.2.tar.xz
>> +       $ tar xf dpdk-19.11.2.tar.xz
>> +       $ export DPDK_DIR=/usr/src/dpdk-stable-19.11.2
>>          $ cd $DPDK_DIR
>>   
>>   #. (Optional) Configure DPDK as a shared library
>> diff --git a/Documentation/topics/dpdk/vhost-user.rst b/Documentation/topics/dpdk/vhost-user.rst
>> index c6c6fd8bd..4bc5aef59 100644
>> --- a/Documentation/topics/dpdk/vhost-user.rst
>> +++ b/Documentation/topics/dpdk/vhost-user.rst
>> @@ -392,9 +392,9 @@ To begin, instantiate a guest as described in :ref:`dpdk-vhost-user` or
>>   DPDK sources to VM and build DPDK::
>>   
>>       $ cd /root/dpdk/
>> -    $ wget https://fast.dpdk.org/rel/dpdk-19.11.tar.xz
>> -    $ tar xf dpdk-19.11.tar.xz
>> -    $ export DPDK_DIR=/root/dpdk/dpdk-19.11
>> +    $ wget https://fast.dpdk.org/rel/dpdk-19.11.2.tar.xz
>> +    $ tar xf dpdk-19.11.2.tar.xz
>> +    $ export DPDK_DIR=/root/dpdk/dpdk-stable-19.11.2
>>       $ export DPDK_TARGET=x86_64-native-linuxapp-gcc
>>       $ export DPDK_BUILD=$DPDK_DIR/$DPDK_TARGET
>>       $ cd $DPDK_DIR
>> diff --git a/Documentation/topics/userspace-tso.rst b/Documentation/topics/userspace-tso.rst
>> index 0fbac93a5..aafa4a1bf 100644
>> --- a/Documentation/topics/userspace-tso.rst
>> +++ b/Documentation/topics/userspace-tso.rst
>> @@ -104,15 +104,6 @@ on ports without TSO support.  That also means guests using vhost-user
>>   in client mode will receive TSO packet regardless of TSO being enabled
>>   or disabled within the guest.
>>   
>> -When the NIC performing the segmentation is using the i40e DPDK PMD, a fix
>> -must be included in the DPDK build, otherwise TSO will not work. The fix can
>> -be found on `DPDK patchwork`__.
>> -
>> -__ https://patches.dpdk.org/patch/64136/
>> -
>> -This fix is expected to be included in the 19.11.1 release. When OVS migrates
>> -to this DPDK release, this limitation can be removed.
>> -
>>   ~~~~~~~~~~~~~~~~~~
>>   Performance Tuning
>>   ~~~~~~~~~~~~~~~~~~
>> diff --git a/NEWS b/NEWS
>> index e52e862e1..e4e926c50 100644
>> --- a/NEWS
>> +++ b/NEWS
>> @@ -13,6 +13,9 @@ Post-v2.13.0
>>        * Add hardware offload support for matching IPv6 protocol (experimental).
>>        * Add hardware offload support for set of IPv6 src/dst/ttl
>>          and tunnel push-output actions (experimental).
>> +     * OVS validated with DPDK 19.11.2, due to the inclusion of fixes for
>> +       CVE-2020-10722, CVE-2020-10723, CVE-2020-10724, CVE-2020-10725 and
>> +       CVE-2020-10726, this DPDK version is strongly recommended to be used.
>>      - Linux datapath:
>>        * Support for kernel versions up to 5.5.x.
>>      - AF_XDP:
>>
> 