[ovs-dev] [PATCH] rpm-fedora: Add missing dist library

Ilya Maximets i.maximets at ovn.org
Wed Jul 15 09:15:42 UTC 2020


On 7/15/20 1:33 AM, William Tu wrote:
> On Tue, Jul 14, 2020 at 03:40:39PM -0700, Gregory Rose wrote:
>>
>>
>> On 7/14/2020 1:49 PM, Greg Rose wrote:
>>> libopenvswitchavx512.a is needed for the fedora rpm spec.
>>>
>>> Signed-off-by: Greg Rose <gvrose8192 at gmail.com>
>>> ---
>>>  rhel/openvswitch-fedora.spec.in | 1 +
>>>  1 file changed, 1 insertion(+)
>>>
>>> diff --git a/rhel/openvswitch-fedora.spec.in b/rhel/openvswitch-fedora.spec.in
>>> index 7bc8c34..154b49e 100644
>>> --- a/rhel/openvswitch-fedora.spec.in
>>> +++ b/rhel/openvswitch-fedora.spec.in
>>> @@ -457,6 +457,7 @@ fi
>>>  %{_bindir}/ovs-pki
>>>  %{_bindir}/vtep-ctl
>>>  %{_libdir}/lib*.so.*
>>> +%{_libdir}/libopenvswitchavx512.a
> How come before the avx512 patch series, we don't need to put libopenvswitch.a here?
> And now we need to add libopenvswitchavx512.a?
> Do we need to also add other .a files such as libsflow.a, libopenvswitch.a?

It seems like the real issue is that rpm build requests to build shared
libraries only, but we're building this static library for some reason.

We should not include it into the package.  I think, we need to fix the
build process and avoid building it in a first place.

Harry, Ian, could you, please, take a look?

Best regards, Ilya Maximets.


More information about the dev mailing list