[ovs-dev] [PATCH v12] AB bonding: Add "primary" interface concept

Ilya Maximets i.maximets at ovn.org
Fri Jul 17 02:05:38 UTC 2020


On 7/10/20 4:20 PM, Flavio Leitner wrote:
> On Thu, Jul 09, 2020 at 04:57:47PM -0700, Jeff Squyres via dev wrote:
>> In AB bonding, if the current active slave becomes disabled, a
>> replacement slave is arbitrarily picked from the remaining set of
>> enabled slaves.  This commit adds the concept of a "primary" slave: an
>> interface that will always be (or become) the current active slave if
>> it is enabled.
>>
>> The rationale for this functionality is to allow the designation of a
>> preferred interface for a given bond.  For example:
>>
>> 1. Bond is created with interfaces p1 (primary) and p2, both enabled.
>> 2. p1 becomes the current active slave (because it was designated as
>>    the primary).
>> 3. Later, p1 fails/becomes disabled.
>> 4. p2 is chosen to become the current active slave.
>> 5. Later, p1 becomes re-enabled.
>> 6. p1 is chosen to become the current active slave (because it was
>>    designated as the primary)
>>
>> Note that p1 becomes the active slave once it becomes re-enabled, even
>> if nothing has happened to p2.
>>
>> This "primary" concept exists in Linux kernel network interface
>> bonding, but did not previously exist in OVS bonding.
>>
>> Only one primary slave inteface is supported per bond, and is only
>> supported for active/backup bonding.
>>
>> The primary slave interface is designated via
>> "other_config:bond-primary" when creating a bond.
>>
>> Also, while adding tests for the "primary" concept, make a few small
>> improvements to the non-primary AB bonding test.
>>
>> Signed-off-by: Jeff Squyres <jsquyres at cisco.com>
>> Reviewed-by: Aaron Conole <aconole at redhat.com>
>> Tested-by: Greg Rose <gvrose8192 at gmail.com>
>> Acked-by: Greg Rose <gvrose8192 at gmail.com>
>> ---
> 
> Acked-by: Flavio Leitner <fbl at sysclose.org>

Thanks, everyone!
Applied to master.

Best regards, Ilya Maximets.


More information about the dev mailing list