[ovs-dev] [PATCH v3 3/4] netdev-offload: Add xdp flow api provider

[Toshiaki Makita]

On 2020/07/28 3:14, William Tu wrote:
> On Sun, Jul 26, 2020 at 9:55 AM Toshiaki Makita
> <toshiaki.makita1 at gmail.com> wrote:
>>
> snip
> 
>>>> How about doing s.t like:
>>>> --enable-afxdp: the current one on master without the xdp offload program
>>>> --enable-afxdp-with-bpf: the afxdp one plus your xdp offload program
>>>>
>>>> So that when users only --enable-afxdp, it doesn't need to compile in the
>>>> lib/netdev-offload-xdp.* and bpf/*
>>>
>>> Let me clarify it.
>>>
>>> Currently,
>>>
>>> --enable-afxdp: build lib/netdev-afxdp* and lib/netdev-offload-xdp*
>>> --enable-bpf: build bpf/*
>>>
>>> Do you sugguest this?
>>>
>>> --enable-afxdp: build lib/netdev-afxdp*
>>> --enable-afxdp-with-bpf: build lib/netdev-afxdp*, lib/netdev-offload-xdp*, and bpf/*
>>
>> Maybe we should not introduce this kind of overlapping?
>> (enable-afxdp-with-bpf should not include enable-afxdp)
>>
>> How about this?
>>
>> --enable-afxdp: build lib/netdev-afxdp*
>> --enable-xdp-offload: build lib/netdev-offload-xdp*
>> --enable-bpf: build bpf/*
>>
>> I thought the following is also possible:
>>
>> --enable-afxdp: build lib/netdev-afxdp*
>> --enable-afxdp=offload: build lib/netdev-afxdp* and lib/netdev-offload-xdp*
>> --enable-bpf: build bpf/*
> 
> But isn't --enable-afxdp-offload has dependency on --enable-bpf?

Strictly speaking, no.
--enable-bpf just builds a reference program.
Users can use it, but alternatively they can use their own programs built in their own build system as well.
However, since that's probably rare, if you like I'll merge --enable-bpf into --enable-xdp-offload.
If necessary, we can add --enable-bpf=no option later on.

Toshiaki Makita