[ovs-dev] [PATCH ovn] expr.c: Fix argument type of expr_write_scope().

Mark Michelson mmichels at redhat.com
Thu Jul 30 14:06:26 UTC 2020


Thanks, Han. I guess I need to upgrade gcc since I didn't see this locally.


On 7/29/20 9:44 PM, Han Zhou wrote:
> There is compile error introduced by the commit 2054d01247.
> ***
> ../lib/expr.c:3328:6: error: symbol 'expr_type_check' redeclared with different
> type (originally declared at ../include/ovn/expr.h:481) - incompatible argument
> 4 (different signedness)
> Makefile:1971: recipe for target 'lib/expr.lo' failed
> ***
> 
> Fixes: 2054d01247 ("Add expression writeability scopes.")
> Signed-off-by: Han Zhou <hzhou at ovn.org>
> ---
>   lib/expr.c | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/lib/expr.c b/lib/expr.c
> index c07e7dd..6fb9675 100644
> --- a/lib/expr.c
> +++ b/lib/expr.c
> @@ -3327,7 +3327,7 @@ expr_evaluate(const struct expr *e, const struct flow *uflow,
>    * must free(). */
>   char * OVS_WARN_UNUSED_RESULT
>   expr_type_check(const struct expr_field *f, int n_bits, bool rw,
> -                uint32_t write_scope)
> +                enum expr_write_scope write_scope)
>   {
>       if (n_bits != f->n_bits) {
>           if (n_bits && f->n_bits) {
> 



More information about the dev mailing list