[ovs-dev] [PATCH V2 00/12] netdev datapath offload: Support IPv6 and VXLAN encap

[Sriharsha Basavapatna]

Hi Eli,

I've reviewed and responded with 'acked-by' for patches #1 - #4, #8,
#9, #12. I have a minor comment on patch #7, otherwise it looks good
to me. For patches #5, #6, #10, #11, though I'm ok with the changes,
I'd prefer to have someone more familiar with those areas review the
patches and ack them.

Thanks,
-Harsha


On Wed, May 27, 2020 at 9:31 PM Eli Britstein <elibr at mellanox.com> wrote:
>
> This patch set includes additional offloads - IPv6 and VXLAN encap, and
> enhanced logging to increase debugability.
>
> Patches #1-#8:   Add support for offloads of IPv6 patterns, partial
>                  TCP/UDP ports, set IPv6 and encap actions
>                  (clone/output).
> Patch #9:        Bug fix of partial offloads.
> Patches #10-#11: Enhance log prints for debugability.
> Patch #12:       Fix Ethernet matching for type only.
>
> v2-v1:
> - Removed redundant out label.
> - Added a patch to fix dl_type match only.
>
> Travis:
> v1: https://travis-ci.org/github/elibritstein/OVS/builds/688413350
> v2: https://travis-ci.org/github/elibritstein/OVS/builds/691375847
>
>
> Eli Britstein (10):
>   netdev-offload-dpdk: Remove pre-validate of patterns function
>   netdev-offload-dpdk: Add IPv6 pattern matching
>   netdev-offload-dpdk: Support offload of set IPv6 actions
>   netdev-offload-dpdk: Support partial TCP/UDP port matching
>   netdev-offload-dpdk: Support offload of clone tnl_push/output actions
>   netdev-offload-dpdk: Support tnl/push using vxlan encap attribute
>   dpif-netdev: Don't use zero flow mark
>   dpif-netdev: Add mega ufid in flow add log
>   netdev-offload-dpdk: Add testpmd log commands
>   netdev-offload-dpdk: Fix Ethernet matching for type only
>
> Ilya Maximets (2):
>   netdev: Allow storing dpif type into netdev structure.
>   netdev-offload: Use dpif type instead of class.
>
>  Documentation/howto/dpdk.rst  |   4 +-
>  NEWS                          |   3 +
>  lib/dpif-netdev.c             |  26 +-
>  lib/dpif-netlink.c            |  23 +-
>  lib/dpif.c                    |  21 +-
>  lib/netdev-offload-dpdk.c     | 649 +++++++++++++++++++++++++++++++++++-------
>  lib/netdev-offload-tc.c       |   3 +-
>  lib/netdev-offload.c          |  51 ++--
>  lib/netdev-offload.h          |  16 +-
>  lib/netdev-provider.h         |   3 +-
>  lib/netdev.c                  |  16 ++
>  lib/netdev.h                  |   2 +
>  ofproto/ofproto-dpif-upcall.c |   5 +-
>  tests/dpif-netdev.at          |  20 +-
>  tests/ofproto-macros.at       |   3 +-
>  15 files changed, 657 insertions(+), 188 deletions(-)
>
> --
> 2.14.5
>