[ovs-dev] [PATCH v1] Enable VXLAN TSO for DPDK datapath

0-day Robot robot at bytheb.org
Mon Jun 1 22:28:13 UTC 2020


Bleep bloop.  Greetings yang_y_yi, I am a robot and I have tried out your patch.
Thanks for your contribution.

I encountered some error that I wasn't expecting.  See the details below.


checkpatch:
ERROR: Inappropriate bracing around statement
ERROR: C99 style comment
#215 FILE: lib/netdev-dpdk.c:2219:
    if ((mbuf->ol_flags & PKT_TX_L4_MASK) == PKT_TX_UDP_CKSUM) { //UDP

ERROR: C99 style comment
#241 FILE: lib/netdev-dpdk.c:2240:
            //mbuf->tso_segsz = dev->mtu - mbuf->l3_len - mbuf->l4_len;

Lines checked: 424, Warnings: 0, Errors: 3


build:
 dp_packet_hwol_set_l2_len(struct dp_packet *b, int l2_len)
                                             ^
lib/dp-packet.h:1076:52: error: unused parameter 'l2_len' [-Werror=unused-parameter]
 dp_packet_hwol_set_l2_len(struct dp_packet *b, int l2_len)
                                                    ^
lib/dp-packet.h: In function 'dp_packet_hwol_set_l3_len':
lib/dp-packet.h:1082:45: error: unused parameter 'b' [-Werror=unused-parameter]
 dp_packet_hwol_set_l3_len(struct dp_packet *b, int l3_len)
                                             ^
lib/dp-packet.h:1082:52: error: unused parameter 'l3_len' [-Werror=unused-parameter]
 dp_packet_hwol_set_l3_len(struct dp_packet *b, int l3_len)
                                                    ^
lib/dp-packet.h: In function 'dp_packet_hwol_set_l4_len':
lib/dp-packet.h:1088:45: error: unused parameter 'b' [-Werror=unused-parameter]
 dp_packet_hwol_set_l4_len(struct dp_packet *b, int l4_len)
                                             ^
lib/dp-packet.h:1088:52: error: unused parameter 'l4_len' [-Werror=unused-parameter]
 dp_packet_hwol_set_l4_len(struct dp_packet *b, int l4_len)
                                                    ^
cc1: all warnings being treated as errors
make[2]: *** [lib/bfd.lo] Error 1
make[2]: Leaving directory `/var/lib/jenkins/jobs/0day_robot_upstream_build_from_pw/workspace'
make[1]: *** [all-recursive] Error 1
make[1]: Leaving directory `/var/lib/jenkins/jobs/0day_robot_upstream_build_from_pw/workspace'
make: *** [all] Error 2


Please check this out.  If you feel there has been an error, please email aconole at redhat.com

Thanks,
0-day Robot


More information about the dev mailing list