[ovs-dev] [PATCH 1/2] netdev-offload: Implement terse dump support

Aaron Conole aconole at redhat.com
Tue Jun 2 13:11:27 UTC 2020


Roi Dayan <roid at mellanox.com> writes:

> On 2020-06-02 1:35 AM, 0-day Robot wrote:
>> Bleep bloop.  Greetings Roi Dayan, I am a robot and I have tried out your patch.
>> Thanks for your contribution.
>> 
>> I encountered some error that I wasn't expecting.  See the details below.
>> 
>> 
>> checkpatch:
>> WARNING: Line is 80 characters long (recommended limit is 79)
>> #252 FILE: lib/netdev-offload-tc.c:1824:
>>     parse_tc_flower_to_match(&flower, match, actions, stats, attrs, buf, false);
>> 
>> Lines checked: 368, Warnings: 1, Errors: 0
>> 
>> 
>> Please check this out.  If you feel there has been an error, please email aconole at redhat.com
>> 
>> Thanks,
>> 0-day Robot
>> 
>
> it is pretty short line so we didn't want to do redundant line breaks.
> is it important or can we skip this?

It's not that important, I think.

> should we maybe update ovs checkpatch to 100 chars to match
> linux kernel? i guess the current 79 is also started because
> the kernel was 79?

I don't have a strong opinion on it, but maybe someone else does.



More information about the dev mailing list