[ovs-dev] [PATCH] Make the notify() calls work with IPv6

[Michele Baldessari]

On Sun, May 31, 2020 at 12:19:07PM +0100, Gabriele Cerami wrote:
> AFAIK OVN patches should have PATCH ovn prefix :)

Ah ok, I guess last time I tweaked the OCF resource agent it was still
in the ovs repo.

> On 31 May, Michele Baldessari wrote:
> > ---
> >  utilities/ovndb-servers.ocf | 7 +++++--
> >  1 file changed, 5 insertions(+), 2 deletions(-)
> > 
> > diff --git a/utilities/ovndb-servers.ocf b/utilities/ovndb-servers.ocf
> > index 56c2bc3227c3..2181bc5e273a 100755
> > --- a/utilities/ovndb-servers.ocf
> > +++ b/utilities/ovndb-servers.ocf
> > @@ -251,11 +251,14 @@ ovsdb_server_notify() {
> >          else
> >             LISTEN_ON_IP=${MASTER_IP}
> 
> May I suggest a less intrusive one liner ? LISTEN_ON_IP=$(sed -e 's/\(\[\|\]\|:\)/\\\1/g' <<< ${MASTER_IP})

Sure can do, although I need to retest everything then.

thanks

> >          fi
> > +        # ovn-nbctl wants ':[]' characters to be escaped. We do so in order
> > +        # to make this work when MASTER_IP is an IPv6 address
> > +        LISTEN_ON_IP_ESCAPED=$(echo ${LISTEN_ON_IP} | sed -e 's/\(\[\|\]\|:\)/\\\1/g')
> 

-- 
Michele Baldessari            <michele at acksyn.org>
C2A5 9DA3 9961 4FFB E01B  D0BC DDD4 DCCB 7515 5C6D