[ovs-dev] [PATCH v3 1/2] Datapath: New MPLS actions for layer 2 tunnelling

[Ilya Maximets]

On 5/8/20 7:38 AM, Martin Varghese wrote:
> It is already handled in path. Did i miss something here?

Robot applied only patch #1 from the series and failed to build.
You need to make sure that it's possible to build and run OVS while
having only first patch applied or combine both patches.

The reason is that if someone will try to bisect some issue he/she
should be able to build and run successfully on any given commit
in a git history.

Best regards, Ilya Maximets.

> 
> diff --git a/lib/dpif-netdev.c b/lib/dpif-netdev.c
> index 51c8885..39a38cc 100644
> --- a/lib/dpif-netdev.c
> +++ b/lib/dpif-netdev.c
> @@ -7496,6 +7496,7 @@ dp_execute_cb(void *aux_, struct dp_packet_batch
> *packets_,
>      case OVS_ACTION_ATTR_CT_CLEAR:
>      case OVS_ACTION_ATTR_CHECK_PKT_LEN:
>      case OVS_ACTION_ATTR_DROP:
> +    case OVS_ACTION_ATTR_ADD_MPLS:
>      case __OVS_ACTION_ATTR_MAX:
>          OVS_NOT_REACHED();
>      }
> 
> 
> On 5/8/20, 0-day Robot <robot at bytheb.org> wrote:
>> Bleep bloop.  Greetings Martin Varghese, I am a robot and I have tried out
>> your patch.
>> Thanks for your contribution.
>>
>> I encountered some error that I wasn't expecting.  See the details below.
>>
>>
>> build:
>> /bin/sh ./libtool  --tag=CC   --mode=compile gcc -std=gnu99 -DHAVE_CONFIG_H
>> -I.    -I ./include -I ./include -I ./lib -I ./lib    -Wstrict-prototypes
>> -Wall -Wextra -Wno-sign-compare -Wpointer-arith -Wformat -Wformat-security
>> -Wswitch-enum -Wunused-parameter -Wbad-function-cast -Wcast-align
>> -Wstrict-prototypes -Wold-style-definition -Wmissing-prototypes
>> -Wmissing-field-initializers -fno-strict-aliasing -Wshadow -Werror -Werror
>> -g -O2 -MT lib/dpctl.lo -MD -MP -MF $depbase.Tpo -c -o lib/dpctl.lo
>> lib/dpctl.c &&\
>> mv -f $depbase.Tpo $depbase.Plo
>> libtool: compile:  gcc -std=gnu99 -DHAVE_CONFIG_H -I. -I ./include -I
>> ./include -I ./lib -I ./lib -Wstrict-prototypes -Wall -Wextra
>> -Wno-sign-compare -Wpointer-arith -Wformat -Wformat-security -Wswitch-enum
>> -Wunused-parameter -Wbad-function-cast -Wcast-align -Wstrict-prototypes
>> -Wold-style-definition -Wmissing-prototypes -Wmissing-field-initializers
>> -fno-strict-aliasing -Wshadow -Werror -Werror -g -O2 -MT lib/dpctl.lo -MD
>> -MP -MF lib/.deps/dpctl.Tpo -c lib/dpctl.c -o lib/dpctl.o
>> depbase=`echo lib/dp-packet.lo | sed 's|[^/]*$|.deps/&|;s|\.lo$||'`;\
>> /bin/sh ./libtool  --tag=CC   --mode=compile gcc -std=gnu99 -DHAVE_CONFIG_H
>> -I.    -I ./include -I ./include -I ./lib -I ./lib    -Wstrict-prototypes
>> -Wall -Wextra -Wno-sign-compare -Wpointer-arith -Wformat -Wformat-security
>> -Wswitch-enum -Wunused-parameter -Wbad-function-cast -Wcast-align
>> -Wstrict-prototypes -Wold-style-definition -Wmissing-prototypes
>> -Wmissing-field-initializers -fno-strict-aliasing -Wshadow -Werror -Werror
>> -g -O2 -MT lib/dp-packet.lo -MD -MP -MF $depbase.Tpo -c -o lib/dp-packet.lo
>> lib/dp-packet.c &&\
>> mv -f $depbase.Tpo $depbase.Plo
>> libtool: compile:  gcc -std=gnu99 -DHAVE_CONFIG_H -I. -I ./include -I
>> ./include -I ./lib -I ./lib -Wstrict-prototypes -Wall -Wextra
>> -Wno-sign-compare -Wpointer-arith -Wformat -Wformat-security -Wswitch-enum
>> -Wunused-parameter -Wbad-function-cast -Wcast-align -Wstrict-prototypes
>> -Wold-style-definition -Wmissing-prototypes -Wmissing-field-initializers
>> -fno-strict-aliasing -Wshadow -Werror -Werror -g -O2 -MT lib/dp-packet.lo
>> -MD -MP -MF lib/.deps/dp-packet.Tpo -c lib/dp-packet.c -o lib/dp-packet.o
>> depbase=`echo lib/dpif-netdev-lookup-generic.lo | sed
>> 's|[^/]*$|.deps/&|;s|\.lo$||'`;\
>> /bin/sh ./libtool  --tag=CC   --mode=compile gcc -std=gnu99 -DHAVE_CONFIG_H
>> -I.    -I ./include -I ./include -I ./lib -I ./lib    -Wstrict-prototypes
>> -Wall -Wextra -Wno-sign-compare -Wpointer-arith -Wformat -Wformat-security
>> -Wswitch-enum -Wunused-parameter -Wbad-function-cast -Wcast-align
>> -Wstrict-prototypes -Wold-style-definition -Wmissing-prototypes
>> -Wmissing-field-initializers -fno-strict-aliasing -Wshadow -Werror -Werror
>> -g -O2 -MT lib/dpif-netdev-lookup-generic.lo -MD -MP -MF $depbase.Tpo -c -o
>> lib/dpif-netdev-lookup-generic.lo lib/dpif-netdev-lookup-generic.c &&\
>> mv -f $depbase.Tpo $depbase.Plo
>> libtool: compile:  gcc -std=gnu99 -DHAVE_CONFIG_H -I. -I ./include -I
>> ./include -I ./lib -I ./lib -Wstrict-prototypes -Wall -Wextra
>> -Wno-sign-compare -Wpointer-arith -Wformat -Wformat-security -Wswitch-enum
>> -Wunused-parameter -Wbad-function-cast -Wcast-align -Wstrict-prototypes
>> -Wold-style-definition -Wmissing-prototypes -Wmissing-field-initializers
>> -fno-strict-aliasing -Wshadow -Werror -Werror -g -O2 -MT
>> lib/dpif-netdev-lookup-generic.lo -MD -MP -MF
>> lib/.deps/dpif-netdev-lookup-generic.Tpo -c lib/dpif-netdev-lookup-generic.c
>> -o lib/dpif-netdev-lookup-generic.o
>> depbase=`echo lib/dpif-netdev.lo | sed 's|[^/]*$|.deps/&|;s|\.lo$||'`;\
>> /bin/sh ./libtool  --tag=CC   --mode=compile gcc -std=gnu99 -DHAVE_CONFIG_H
>> -I.    -I ./include -I ./include -I ./lib -I ./lib    -Wstrict-prototypes
>> -Wall -Wextra -Wno-sign-compare -Wpointer-arith -Wformat -Wformat-security
>> -Wswitch-enum -Wunused-parameter -Wbad-function-cast -Wcast-align
>> -Wstrict-prototypes -Wold-style-definition -Wmissing-prototypes
>> -Wmissing-field-initializers -fno-strict-aliasing -Wshadow -Werror -Werror
>> -g -O2 -MT lib/dpif-netdev.lo -MD -MP -MF $depbase.Tpo -c -o
>> lib/dpif-netdev.lo lib/dpif-netdev.c &&\
>> mv -f $depbase.Tpo $depbase.Plo
>> libtool: compile:  gcc -std=gnu99 -DHAVE_CONFIG_H -I. -I ./include -I
>> ./include -I ./lib -I ./lib -Wstrict-prototypes -Wall -Wextra
>> -Wno-sign-compare -Wpointer-arith -Wformat -Wformat-security -Wswitch-enum
>> -Wunused-parameter -Wbad-function-cast -Wcast-align -Wstrict-prototypes
>> -Wold-style-definition -Wmissing-prototypes -Wmissing-field-initializers
>> -fno-strict-aliasing -Wshadow -Werror -Werror -g -O2 -MT lib/dpif-netdev.lo
>> -MD -MP -MF lib/.deps/dpif-netdev.Tpo -c lib/dpif-netdev.c -o
>> lib/dpif-netdev.o
>> lib/dpif-netdev.c: In function 'dp_execute_cb':
>> lib/dpif-netdev.c:7160:5: error: enumeration value
>> 'OVS_ACTION_ATTR_ADD_MPLS' not handled in switch [-Werror=switch]
>>      switch ((enum ovs_action_attr)type) {
>>      ^
>> cc1: all warnings being treated as errors
>> make[2]: *** [lib/dpif-netdev.lo] Error 1
>> make[2]: Leaving directory
>> `/var/lib/jenkins/jobs/0day_robot_upstream_build_from_pw/workspace'
>> make[1]: *** [all-recursive] Error 1
>> make[1]: Leaving directory
>> `/var/lib/jenkins/jobs/0day_robot_upstream_build_from_pw/workspace'
>> make: *** [all] Error 2
>>
>>
>> Please check this out.  If you feel there has been an error, please email
>> aconole at redhat.com
>>
>> Thanks,
>> 0-day Robot
>>
> _______________________________________________
> dev mailing list
> dev at openvswitch.org
> https://mail.openvswitch.org/mailman/listinfo/ovs-dev
>