[ovs-dev] [PATCH v2 3/5] Fixes for build with extra warnings

0-day Robot robot at bytheb.org
Fri Jun 5 20:37:30 UTC 2020


Bleep bloop.  Greetings Anton Ivanov, I am a robot and I have tried out your patch.
Thanks for your contribution.

I encountered some error that I wasn't expecting.  See the details below.


build:
/bin/sh ./libtool  --tag=CC   --mode=compile gcc -std=gnu99 -DHAVE_CONFIG_H -I.    -I ./include -I ./include -I ./lib -I ./lib    -Wstrict-prototypes -Wall -Wextra -Wno-sign-compare -Wpointer-arith -Wformat -Wformat-security -Wswitch-enum -Wunused-parameter -Wbad-function-cast -Wcast-align -Wstrict-prototypes -Wold-style-definition -Wmissing-prototypes -Wmissing-field-initializers -fno-strict-aliasing -Wshadow -Werror -Werror   -g -O2 -MT lib/async-append-aio.lo -MD -MP -MF $depbase.Tpo -c -o lib/async-append-aio.lo lib/async-append-aio.c &&\
mv -f $depbase.Tpo $depbase.Plo
libtool: compile:  gcc -std=gnu99 -DHAVE_CONFIG_H -I. -I ./include -I ./include -I ./lib -I ./lib -Wstrict-prototypes -Wall -Wextra -Wno-sign-compare -Wpointer-arith -Wformat -Wformat-security -Wswitch-enum -Wunused-parameter -Wbad-function-cast -Wcast-align -Wstrict-prototypes -Wold-style-definition -Wmissing-prototypes -Wmissing-field-initializers -fno-strict-aliasing -Wshadow -Werror -Werror -g -O2 -MT lib/async-append-aio.lo -MD -MP -MF lib/.deps/async-append-aio.Tpo -c lib/async-append-aio.c -o lib/async-append-aio.o
lib/async-append-aio.c: In function 'async_append_is_full':
lib/async-append-aio.c:83:13: error: passing argument 1 of 'byteq_is_full' discards 'const' qualifier from pointer target type [-Werror]
             || byteq_is_full(&ap->byteq));
             ^
In file included from lib/async-append-aio.c:28:0:
lib/byteq.h:37:6: note: expected 'struct byteq *' but argument is of type 'const struct byteq *'
 bool byteq_is_full(struct byteq *);
      ^
lib/async-append-aio.c: In function 'async_append_is_empty':
lib/async-append-aio.c:89:5: error: passing argument 1 of 'byteq_is_empty' discards 'const' qualifier from pointer target type [-Werror]
     return byteq_is_empty(&ap->byteq);
     ^
In file included from lib/async-append-aio.c:28:0:
lib/byteq.h:36:6: note: expected 'struct byteq *' but argument is of type 'const struct byteq *'
 bool byteq_is_empty(struct byteq *);
      ^
cc1: all warnings being treated as errors
make[2]: *** [lib/async-append-aio.lo] Error 1
make[2]: Leaving directory `/var/lib/jenkins/jobs/0day_robot_upstream_build_from_pw/workspace'
make[1]: *** [all-recursive] Error 1
make[1]: Leaving directory `/var/lib/jenkins/jobs/0day_robot_upstream_build_from_pw/workspace'
make: *** [all] Error 2


Please check this out.  If you feel there has been an error, please email aconole at redhat.com

Thanks,
0-day Robot


More information about the dev mailing list