[ovs-dev] [PATCH] Make polling fds persistent

0-day Robot robot at bytheb.org
Wed Jun 10 13:16:56 UTC 2020


Bleep bloop.  Greetings Anton Ivanov, I am a robot and I have tried out your patch.
Thanks for your contribution.

I encountered some error that I wasn't expecting.  See the details below.


checkpatch:
WARNING: Line is 88 characters long (recommended limit is 79)
#124 FILE: lib/poll-loop-unix.c:64:
    struct pollfd * watched;    /* list of descriptors and event masks passed to poll */

WARNING: Line is 82 characters long (recommended limit is 79)
#189 FILE: lib/poll-loop-unix.c:129:
            resized_watched = xzalloc(sizeof(struct pollfd) * loop->watched_size);

WARNING: Line is 101 characters long (recommended limit is 79)
#190 FILE: lib/poll-loop-unix.c:130:
            memcpy(resized_watched, loop->watched, sizeof(struct pollfd) * (loop->watched_size - 1));

WARNING: Line is 84 characters long (recommended limit is 79)
#417 FILE: lib/poll-loop-unix.c:357:
                loop->watched[i] = loop->watched[hmap_count(&loop->poll_nodes) - 1];

Lines checked: 564, Warnings: 4, Errors: 0


Please check this out.  If you feel there has been an error, please email aconole at redhat.com

Thanks,
0-day Robot


More information about the dev mailing list