[ovs-dev] [PATCH] checkpatch: Increase recommended line length to 100

Aaron Conole aconole at redhat.com
Tue Jun 16 14:35:41 UTC 2020


Simon Horman <simon.horman at netronome.com> writes:

> On Tue, Jun 16, 2020 at 04:14:55PM +0300, Roi Dayan wrote:
>> 
>> 
>> On 2020-06-11 1:09 PM, Roi Dayan wrote:
>> > This is to match a recent kernel checkpatch change that
>> > also increased it to 100 line length.
>> > 
>> > Signed-off-by: Roi Dayan <roid at mellanox.com>
>> > ---
>> >  utilities/checkpatch.py | 4 ++--
>> >  1 file changed, 2 insertions(+), 2 deletions(-)
>> > 
>> > diff --git a/utilities/checkpatch.py b/utilities/checkpatch.py
>> > index fc9e20bf1b5f..80ee6d827567 100755
>> > --- a/utilities/checkpatch.py
>> > +++ b/utilities/checkpatch.py
>> > @@ -287,8 +287,8 @@ def pointer_whitespace_check(line):
>> >  
>> >  def line_length_check(line):
>> >      """Return TRUE if the line length is too long"""
>> > -    if len(line) > 79:
>> > -        print_warning("Line is %d characters long (recommended limit is 79)"
>> > +    if len(line) > 100:
>> > +        print_warning("Line is %d characters long (recommended limit is 100)"
>> >                        % len(line))
>> >          return True
>> >      return False
>> > 
>> 
>> 
>> Hi, 
>> 
>> Any comments on this?
>
> Reviewed-by: Simon Horman <simon.horman at netronome.com>

Acked-by: Aaron Conole <aconole at redhat.com>



More information about the dev mailing list