[ovs-dev] [PATCH v3 3/7] dpif-netdev: add subtable-lookup-get command for usability

Van Haaren, Harry harry.van.haaren at intel.com
Wed Jun 17 15:50:48 UTC 2020


> -----Original Message-----
> From: William Tu <u9012063 at gmail.com>
> Sent: Tuesday, June 16, 2020 4:42 PM
> To: Van Haaren, Harry <harry.van.haaren at intel.com>
> Cc: ovs-dev <ovs-dev at openvswitch.org>; Stokes, Ian <ian.stokes at intel.com>;
> Ilya Maximets <i.maximets at ovn.org>; Federico Iezzi <fiezzi at redhat.com>
> Subject: Re: [PATCH v3 3/7] dpif-netdev: add subtable-lookup-get command for
> usability
> 
> On Wed, Jun 10, 2020 at 3:47 AM Harry van Haaren
> <harry.van.haaren at intel.com> wrote:
> >
> > This commit introduces a new command, "dpif-netdev/subtable-lookup-get"
> add prio

Hey William,

Just reviewing your FB in detail here, today the commands work as follows:
- the "set" command is "subtable-lookup-prio-set"
- the "get" command is "subtable-lookup-get"       // Note : no "prio" here

This is done on purpose - the get returns the list of subtable lookup implementations,
and is not really technically directly to do with "prio" . It does however, return the priority too...

Open to suggestions, would the more similar commands below be better?
subtable-lookup-prio-get
subtable-lookup-prio-set

Regards, -Harry


More information about the dev mailing list