[ovs-dev] [PATCH v2] checkpatch: Increase recommended line length to 100

Roi Dayan roid at mellanox.com
Thu Jun 18 18:17:49 UTC 2020


This is to match a recent kernel checkpatch change that
also increased it to 100 line length.

Signed-off-by: Roi Dayan <roid at mellanox.com>
Reviewed-by: Simon Horman <simon.horman at netronome.com>
Acked-by: Aaron Conole <aconole at redhat.com>
---

Notes:
    v2
    - update docs
    - add ack from Simon and Aaron

 Documentation/internals/contributing/coding-style-windows.rst | 2 +-
 Documentation/internals/contributing/coding-style.rst         | 2 +-
 Documentation/internals/contributing/documentation-style.rst  | 2 +-
 utilities/checkpatch.py                                       | 4 ++--
 4 files changed, 5 insertions(+), 5 deletions(-)

diff --git a/Documentation/internals/contributing/coding-style-windows.rst b/Documentation/internals/contributing/coding-style-windows.rst
index 1edf2285ff3c..a72d9fb619e7 100644
--- a/Documentation/internals/contributing/coding-style-windows.rst
+++ b/Documentation/internals/contributing/coding-style-windows.rst
@@ -38,7 +38,7 @@ kernel/driver code.  They are noted as follows:
 Basics
 ------
 
-- Limit lines to 79 characters.
+- Limit lines to 100 characters.
 
   Many times, this is not possible due to long names of functions and it is
   fine to go beyond the characters limit.  One common example is when calling
diff --git a/Documentation/internals/contributing/coding-style.rst b/Documentation/internals/contributing/coding-style.rst
index f70f783add08..62adfe186347 100644
--- a/Documentation/internals/contributing/coding-style.rst
+++ b/Documentation/internals/contributing/coding-style.rst
@@ -43,7 +43,7 @@ The following GNU indent options approximate this style.
 Basics
 ------
 
-- Limit lines to 79 characters.
+- Limit lines to 100 characters.
 
 - Use form feeds (control+L) to divide long source files into logical pieces. A
   form feed should appear as the only character on a line.
diff --git a/Documentation/internals/contributing/documentation-style.rst b/Documentation/internals/contributing/documentation-style.rst
index deb07d9f5dde..8b158de2e188 100644
--- a/Documentation/internals/contributing/documentation-style.rst
+++ b/Documentation/internals/contributing/documentation-style.rst
@@ -64,7 +64,7 @@ Many of the basic documentation guidelines match those of the
   Sphinx extensions can be used, but only for documentation in the
   ``Documentation`` folder.
 
-- Limit lines at 79 characters.
+- Limit lines at 100 characters.
 
   .. note::
 
diff --git a/utilities/checkpatch.py b/utilities/checkpatch.py
index fc9e20bf1b5f..80ee6d827567 100755
--- a/utilities/checkpatch.py
+++ b/utilities/checkpatch.py
@@ -287,8 +287,8 @@ def pointer_whitespace_check(line):
 
 def line_length_check(line):
     """Return TRUE if the line length is too long"""
-    if len(line) > 79:
-        print_warning("Line is %d characters long (recommended limit is 79)"
+    if len(line) > 100:
+        print_warning("Line is %d characters long (recommended limit is 100)"
                       % len(line))
         return True
     return False
-- 
2.8.4



More information about the dev mailing list