[ovs-dev] [PATCH] checkpatch: Increase recommended line length to 100

Roi Dayan roid at mellanox.com
Thu Jun 18 18:08:53 UTC 2020

On 2020-06-18 7:51 PM, Ben Pfaff wrote:
> On Thu, Jun 11, 2020 at 01:09:32PM +0300, Roi Dayan wrote:
>> This is to match a recent kernel checkpatch change that
>> also increased it to 100 line length.
>> Signed-off-by: Roi Dayan <roid at mellanox.com>
> I don't know what you effect you want from this change.
> If you want to keep checkpatch from complaining for long lines in kernel
> code, then this is not the right way, because checkpatch ignores the
> datapath/ directory that contains kernel code.

My intention was actually not for the datapath/ directory.
I am using it when submitting changes to ovs.
I just mentioned I want to match as the kernel because I was thinking
it probably was first set to 79 to match the kernel at first.

> If you want to update OVS coding style to allow longer lines in OVS's
> own code, then the patch should update
> Documentation/internals/contributing/coding-style.rst
> in a few different places, and we should probably discuss it more
> extensively than just a bare ack.

sure. I missed updating the line in the docs.
and yes please, let's do the discussion as needed.
I wanted to get it started so this is why I sent this patch.

i'll send v2 with update to the docs.

More information about the dev mailing list