[ovs-dev] [PATCH V3 01/12] netdev-offload-dpdk: Remove pre-validate of patterns function

Ilya Maximets i.maximets at ovn.org
Mon Jun 22 07:04:45 UTC 2020


On 6/21/20 1:19 PM, Eli Britstein wrote:
> The function of adding patterns by requested matches checks that it
> consumed all the required matches, and err if not. This nullify the
> purpose of the validation function. Future supported matches will only
> change the pattern parsing code.

I think that validation function here is to speed up the process in case
of unsupported offloading patterns.  It saves time for all the not needed
memory allocations and copies.  With this change we will construct all the
patterns and only in the end will realize that we don't need them as the
flow can not be offloaded.

Best regards, Ilya Maximets.


More information about the dev mailing list