[ovs-dev] [PATCH v2] netdev-offload-dpdk: Support offload of VLAN PUSH/POP actions

Ilya Maximets i.maximets at ovn.org
Mon Jun 22 11:58:18 UTC 2020

On 5/29/20 8:33 AM, Sriharsha Basavapatna via dev wrote:
> Parse VLAN PUSH/POP OVS datapath actions and add respective RTE actions.
> Signed-off-by: Sriharsha Basavapatna <sriharsha.basavapatna at broadcom.com>
> ---
> v1->v2:
> * Updated dump_flow_action() to print VLAN Push/Pop actions
> * Updated NEWS, Documentation/howto/dpdk.rst files
> ---


I had to fix missed 'const' qualifiers flagged by sparse:

lib/netdev-offload-dpdk.c:434:71: error: incorrect type in initializer (different modifiers)
lib/netdev-offload-dpdk.c:434:71:    expected struct rte_flow_action_of_set_vlan_pcp *rte_vlan_pcp
lib/netdev-offload-dpdk.c:434:71:    got void const *const conf
lib/netdev-offload-dpdk.c:443:71: error: incorrect type in initializer (different modifiers)
lib/netdev-offload-dpdk.c:443:71:    expected struct rte_flow_action_of_set_vlan_vid *rte_vlan_vid
lib/netdev-offload-dpdk.c:443:71:    got void const *const conf

With this and a couple of minor style fixes applied to master.

Best regards, Ilya Maximets.

More information about the dev mailing list