[ovs-dev] [PATCH ovn] lex: Allow unmasked bits in value/mask tokens.

[Dumitru Ceara]

On 6/24/20 12:47 PM, Numan Siddique wrote:
> 
> 
> On Tue, Jun 23, 2020 at 10:04 PM Mark Michelson <mmichels at redhat.com
> <mailto:mmichels at redhat.com>> wrote:
> 
>     On 6/23/20 11:08 AM, Dumitru Ceara wrote:
>     > On 6/23/20 4:56 PM, Mark Michelson wrote:
>     >> Acked-by: Mark Michelson <mmichels at redhat.com
>     <mailto:mmichels at redhat.com>>
> 
> 
> Thanks Dumitru and Mark (for the reviews).
> 
> I applied this patch to master with the below changes in the
> tests/ovn.at <http://ovn.at>. I was just playing around
> how the patch works and thought we could add this to the test.
> 
> diff --git a/tests/ovn.at <http://ovn.at> b/tests/ovn.at <http://ovn.at>
> index de62f3883..6587fd8ff 100644
> --- a/tests/ovn.at <http://ovn.at>
> +++ b/tests/ovn.at <http://ovn.at>
> @@ -112,6 +112,9 @@ a/b => a error("`/' is only valid as part of `//' or
> `/*'.") b
>  192.168.0.0/255.0.0.0 <http://192.168.0.0/255.0.0.0> => 192.0.0.0/8
> <http://192.0.0.0/8>
>  192.168.0.0/32 <http://192.168.0.0/32>
>  192.168.0.0/255.255.255.255 <http://192.168.0.0/255.255.255.255> =>
> 192.168.0.0/32 <http://192.168.0.0/32>
> +192.168.0.2/32 <http://192.168.0.2/32>
> +192.168.0.2/30 <http://192.168.0.2/30> => 192.168.0.0/30
> <http://192.168.0.0/30>
> +192.168.0.2/24 <http://192.168.0.2/24> => 192.168.0.0/24
> <http://192.168.0.0/24>
>  1.2.3.4:5 <http://1.2.3.4:5> => 1.2.3.4 : 5
>  
>  ::
> 
> Thanks
> Numan
> 

Looks good to me, thanks!

Regards,
Dumitru