[ovs-dev] [PATCH v3 4/4] bpf: Add reference XDP program implementation for netdev-offload-xdp

0-day Robot robot at bytheb.org
Mon Jun 29 16:22:15 UTC 2020


Bleep bloop.  Greetings Toshiaki Makita, I am a robot and I have tried out your patch.
Thanks for your contribution.

I encountered some error that I wasn't expecting.  See the details below.


checkpatch:
WARNING: Line is 83 characters long (recommended limit is 79)
ERROR: Improper whitespace around control block
#488 FILE: bpf/bpf_netlink.h:57:
#define BPF_MAP_NL_ATTR_FOR_EACH(OFF, ATTRS, START, END, IDX, MAX_ATTRS, MAX_LEN) \

WARNING: Comment with 'xxx' marker
#628 FILE: bpf/flowtable_afxdp.c:95:
/* XXX: This size should be uint16_t but needs to be int as kernel has a bug

ERROR: Improper whitespace around control block
#1077 FILE: bpf/flowtable_afxdp.c:544:
    BPF_MAP_NL_ATTR_FOR_EACH(offset, attrs, start, end, i, XDP_MAX_ACTIONS,

Lines checked: 1144, Warnings: 2, Errors: 2


Please check this out.  If you feel there has been an error, please email aconole at redhat.com

Thanks,
0-day Robot


More information about the dev mailing list